Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom settings page #962

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Add custom settings page #962

merged 3 commits into from
Mar 7, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Mar 5, 2024

As requested in #954, this adds examples of agent policy overrides. I've included the warning proposed by Luca here, that it's possible for a custom configuration to break things.

Please see docs preview page

Closes: #954

Copy link

github-actions bot commented Mar 5, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good, added a few suggestions.

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Mar 6, 2024

Thanks @juliaElastic! Nice catches. I've addressed all comments in cfff910.

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilfoyle kilfoyle merged commit 4106015 into elastic:main Mar 7, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Mar 7, 2024
* Add custom settings page

* Fixup

* Fix whitespace; replace policy ID with placeholder

(cherry picked from commit 4106015)
mergify bot pushed a commit that referenced this pull request Mar 7, 2024
* Add custom settings page

* Fixup

* Fix whitespace; replace policy ID with placeholder

(cherry picked from commit 4106015)
kilfoyle added a commit that referenced this pull request Mar 7, 2024
* Add custom settings page

* Fixup

* Fix whitespace; replace policy ID with placeholder

(cherry picked from commit 4106015)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle added a commit that referenced this pull request Mar 7, 2024
* Add custom settings page

* Fixup

* Fix whitespace; replace policy ID with placeholder

(cherry picked from commit 4106015)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST]: Provide additional examples on how to leverage agent_policies overrides
3 participants