Skip to content

Commit

Permalink
[PHP-FPM] Update the request duration field description in Process …
Browse files Browse the repository at this point in the history
…data stream (#4760)

* update field description and dashboard for process data stream

* update changelog.yml
  • Loading branch information
harnish-crest committed Dec 7, 2022
1 parent 5e3cac3 commit 8b04f83
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 15 deletions.
2 changes: 1 addition & 1 deletion packages/php_fpm/_dev/build/docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ This is the `process` data stream. `process` data stream collects metrics like r

{{event "process"}}

{{fields "process"}}
{{fields "process"}}
5 changes: 5 additions & 0 deletions packages/php_fpm/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "0.2.1"
changes:
- description: PHP-FPM Process data stream update field description
type: bugfix
link: https://github.com/elastic/integrations/pull/4760
- version: "0.2.0"
changes:
- description: PHP-FPM integration package with "Process" data stream.
Expand Down
6 changes: 3 additions & 3 deletions packages/php_fpm/data_stream/process/fields/fields.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
metric_type: counter
- name: duration
type: long
description: The total time in seconds spent serving requests.
metric_type: counter
unit: s
description: The duration in microseconds of the requests.
metric_type: gauge
unit: micros
- name: last
type: group
fields:
Expand Down
3 changes: 1 addition & 2 deletions packages/php_fpm/docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ An example event for `process` looks as following:
| input.type | Type of Filebeat input. | keyword | | |
| php_fpm.process.pool.name | The name of the FPM process pool. | keyword | | |
| php_fpm.process.request.count | The total number of requests served. | long | | counter |
| php_fpm.process.request.duration | The total time in seconds spent serving requests. | long | s | counter |
| php_fpm.process.request.duration | The duration in microseconds of the requests. | long | micros | gauge |
| php_fpm.process.request.last.cpu.pct | The %cpu of the last request. This will be 0 if the process is not Idle because the calculation is done when the request processing is complete. | long | percent | gauge |
| php_fpm.process.request.last.memory | The maximum amount of memory consumed by the last request. This will be 0 if the process is not Idle because the calculation is done when the request processing is complete. | long | | gauge |
| php_fpm.process.script | The full path of the script executed by the last request. This will be '-' if not applicable (eg. status page requests). | keyword | | |
Expand All @@ -281,4 +281,3 @@ An example event for `process` looks as following:
| url.original.text | Multi-field of `url.original`. | match_only_text | | |
| user.name | Short name or login of the user. | keyword | | |
| user.name.text | Multi-field of `user.name`. | match_only_text | | |

Binary file modified packages/php_fpm/img/php_fpm-process-dashboard.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
{
"id": "logs-*",
"name": "fd13d0f4-4ec2-44ed-b0f0-43cbefac151e",
"name": "973b088d-1ba7-40f2-9e9d-c911dd80272f",
"type": "index-pattern"
}
],
Expand Down Expand Up @@ -126,7 +126,7 @@
"query": "php_fpm.process.request.duration: *"
},
"isBucketed": false,
"label": "Request duration",
"label": "Request duration (μs)",
"operationType": "last_value",
"params": {
"sortField": "@timestamp"
Expand Down Expand Up @@ -186,7 +186,7 @@
"meta": {
"alias": null,
"disabled": false,
"index": "fd13d0f4-4ec2-44ed-b0f0-43cbefac151e",
"index": "973b088d-1ba7-40f2-9e9d-c911dd80272f",
"key": "event.dataset",
"negate": false,
"params": {
Expand Down Expand Up @@ -669,9 +669,9 @@
"chart_type": "line",
"color": "#68BC00",
"fill": 0.5,
"formatter": "s,humanize,",
"formatter": "default",
"id": "9dfb9434-2dbe-4546-89b1-96efaa41765c",
"label": "Minimum request duration",
"label": "Minimum (μs)",
"line_width": 1,
"metrics": [
{
Expand All @@ -697,9 +697,9 @@
"chart_type": "line",
"color": "rgba(96,146,192,1)",
"fill": 0.5,
"formatter": "s,humanize,",
"formatter": "default",
"id": "16551510-641c-11ed-8aec-4f36d657ecf1",
"label": "Maximum request duration",
"label": "Maximum (μs)",
"line_width": 1,
"metrics": [
{
Expand Down Expand Up @@ -765,7 +765,7 @@
},
{
"id": "logs-*",
"name": "5c4d2a38-4913-43b6-a54a-a56cb1f9bb3d:fd13d0f4-4ec2-44ed-b0f0-43cbefac151e",
"name": "5c4d2a38-4913-43b6-a54a-a56cb1f9bb3d:973b088d-1ba7-40f2-9e9d-c911dd80272f",
"type": "index-pattern"
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/php_fpm/manifest.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
format_version: 2.0.0
name: php_fpm
title: PHP-FPM
version: 0.2.0
version: 0.2.1
description: This Elastic integration collects metrics from PHP-FPM.
type: integration
categories:
Expand Down

0 comments on commit 8b04f83

Please sign in to comment.