Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP-FPM] Update the request duration field description in Process data stream #4760

Merged

Conversation

harnish-crest
Copy link
Contributor

@harnish-crest harnish-crest commented Dec 5, 2022

  • Bug

What does this PR do?

  • Previously we were referring to PHP doc itself, but we found a discrepancy in request duration field. after referring their repo and discussing it with @ManojS-shetty, we are updating the description of it.
  • Update the request duration field description.
  • Update the visualizations related to the request duration field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to (integrations/packages/php_fpm) directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

@harnish-crest harnish-crest requested a review from a team as a code owner December 5, 2022 11:48
@kush-elastic kush-elastic added bug Something isn't working Integration:php-fpm Team:Service-Integrations Label for the Service Integrations team labels Dec 5, 2022
@elasticmachine
Copy link

elasticmachine commented Dec 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-05T12:15:35.202+0000

  • Duration: 17 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic
Copy link
Collaborator

/test

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.0
Classes 100.0% (2/2) 💚 3.0
Methods 100.0% (16/16) 💚 12.903
Lines 95.763% (226/236) 👍 3.83
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic merged commit 8b04f83 into elastic:main Dec 7, 2022
@elasticmachine
Copy link

Package php_fpm - 0.2.1 containing this change is available at https://epr.elastic.co/search?package=php_fpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:php-fpm Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants