Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Create Package for Apache Tomcat Integration #5200

Closed
15 of 17 tasks
SubhrataK opened this issue Feb 7, 2023 · 15 comments
Closed
15 of 17 tasks

[Meta] Create Package for Apache Tomcat Integration #5200

SubhrataK opened this issue Feb 7, 2023 · 15 comments
Assignees

Comments

@SubhrataK
Copy link

SubhrataK commented Feb 7, 2023

The overall scope of this integration is to cover the below mentioned logs and metrics. This will be phased out in multiple releases.

  • Access Logs
  • Catalina Logs
  • Localhost Logs
  • Request Metrics
  • Cache Metrics
  • Thread Pool Metrics
  • Memory Metrics
  • Connection Pool Metrics
  • Session Metrics

As part of Phase 1 of this integration, the following are covered:

Apache Tomcat

Data stream: cache

Data stream: access

Data stream: catalina

Data stream: localhost

Data stream: request

Deprecate Tomcat package

Phase 2 data streams:

Data stream: ConnectionPool

Data stream: ThreadPool

Data stream: Memory

Data stream: Session

In-review PRs

Related Issues

TSDB Issue

Enhancement Requests

Troubleshooting docs / issues

@SubhrataK SubhrataK changed the title Create Apache Tomcat Package Create Package for Apache Tomcat Integration Feb 7, 2023
@niraj-elastic
Copy link
Contributor

As discussed with @ishleenk17, localhost logs are collected as part of this scope since it helps users to monitor application activity. and It monitors HTTP transactions between the application server and the client.

@ishleenk17
Copy link
Contributor

We will be creating a new package for Apache Tomcat (with version 0.0.1) in Technical Preview.
The older package will be slowly deprecated. We should add "To be deprecated" in the title of the Integration and point to the new integration from the older one.

@niraj-elastic
Copy link
Contributor

As discussed with @ishleenk17, filestream input will be used over TCP/UDP inputs for all the logs data streams for now.

@SubhrataK
Copy link
Author

We will be creating a new package for Apache Tomcat (with version 0.0.1) in Technical Preview. The older package will be slowly deprecated. We should add "To be deprecated" in the title of the Integration and point to the new integration from the older one.

The existing package shall be renamed as "Tomcat NetWitness Logs" and the new package shall be named as "Apache Tomcat".
The documentation of the "Tomcat NetWitness Logs" shall be updated to add "To be deprecated" and a link to the new "Apache Tomcat" integration. The new Apache Tomcat integration shall be in Beta.

@lalit-satapathy
Copy link
Collaborator

The existing package shall be renamed as "Tomcat NetWitness Logs" and the new package shall be named as "Apache Tomcat".

Package name in manifest file to be all lower case. Instead of renaming the existing package directory, we can change the title and/or the description?

@ishleenk17
Copy link
Contributor

ishleenk17 commented May 2, 2023

The existing package shall be renamed as "Tomcat NetWitness Logs" and the new package shall be named as "Apache Tomcat".

Package name in manifest file to be all lowercase. Instead of renaming the existing package directory, we can change the title and/or the description?

Clarification:

The package name in the integrations repository will be tomcat for the older one and apache_tomcat for the newer one.
The title (visible to the customer) of the packages will change: The older one will be "Apache Netwitness Logs" and the newer one will be "Apache Tomcat".

@lalit-satapathy : I hope this is what you meant.

@lalit-satapathy
Copy link
Collaborator

  • Please link the deprecation PR in the meta description.
  • Question: I see the documents are separate for each PR. Are the documentation changes of the PRs to be merged and all merge conflicts to be resolved during that process?
  • Is this request data stream PR ready to be merged, since it is not reviewed internally once?

@ishleenk17
Copy link
Contributor

@niraj-elastic : I assume that there are no histogram values in either of the metrics datastream since we are using Prometheus input?

@niraj-elastic
Copy link
Contributor

  • Please link the deprecation PR in the meta description.
  • Question: I see the documents are separate for each PR. Are the documentation changes of the PRs to be merged and all merge conflicts to be resolved during that process?
  • Is this request data stream PR ready to be merged, since it is not reviewed internally once?
  • Sure, updated the meta with the link of package deprecation PR.
  • Yes, once the PR is merged we will resolve the merge conflicts for the next PR.
  • Internally Harnish is reviewing the PRs and I see he has just approved the PR.

@niraj-elastic
Copy link
Contributor

@niraj-elastic : I assume that there are no histogram values in either of the metrics datastream since we are using Prometheus input?

Yes, there are no histogram values

@niraj-elastic
Copy link
Contributor

While developing the integration we we found that in Catalina and Localhost logs timezone offset is not coming, hence the timezone is getting considered UTC by default by date processor. If the event is getting generated in a different timezone then the timestamp needs to get calculated accordingly otherwise by default it will consider as UTC and the timestamp will not be calculated properly. Hence we have introduced a new configuration parameter called Timezone Offset in the configuration section from where the user will be able to provide the timezone in which the events are generated so based on that timestamp calculation will be done in pipeline accordingly and events will be displayed with a correct timestamp.

@rameshelastic rameshelastic changed the title Create Package for Apache Tomcat Integration [Meta] Create Package for Apache Tomcat Integration May 18, 2023
@rameshelastic
Copy link

The following will be covered as part of Phase 2.

Thread Pool Metrics
Memory Metrics
Connection Pool Metrics
Session Metrics

@rameshelastic
Copy link

@milan-elastic , could you please link the Phase 2 items here? thanks!

@ishleenk17 ishleenk17 self-assigned this Sep 12, 2023
@lalit-satapathy
Copy link
Collaborator

@ishleenk17, @milan-elastic,

Anything pending on apache tomcat, since it is made GA now.

@milan-elastic
Copy link
Contributor

@ishleenk17, @milan-elastic,

Anything pending on apache tomcat, since it is made GA now.

Yes, Apache tomcat is GA. hence closing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants