Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tomcat] Deprecate Tomcat package #6091

Merged
merged 2 commits into from
May 7, 2023
Merged

[Tomcat] Deprecate Tomcat package #6091

merged 2 commits into from
May 7, 2023

Conversation

niraj-elastic
Copy link
Contributor

  • Deprecation

What does this PR do?

  • Rename Tomcat integration to Tomcat NetWitness Logs.
  • Add deprecation note in README.md.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/tomcat) directory.
  • Run the following command to run tests. elastic-package test

Related issues

@niraj-elastic niraj-elastic requested a review from a team as a code owner May 4, 2023 13:30
@kush-elastic kush-elastic added enhancement New feature or request Integration:Tomcat Team:Service-Integrations Label for the Service Integrations team labels May 4, 2023
@kush-elastic kush-elastic self-assigned this May 4, 2023
@elasticmachine
Copy link

elasticmachine commented May 4, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-04T13:31:33.093+0000

  • Duration: 16 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 77.778% (7/9) 👍 45.248
Lines 82.143% (46/56) 👎 -17.857
Conditionals 100.0% (0/0) 💚

ishleenk17
ishleenk17 reviewed May 5, 2023
View reviewed changes
packages/tomcat/_dev/build/docs/README.md

This integration is for [Tomcat device's](https://tomcat.apache.org/tomcat-10.0-doc/logging.html) logs. It includes the following
datasets for receiving logs over syslog or read from a file:

- `log` dataset: supports Apache Tomcat logs.

Note:
- To collect Apache Tomcat Logs and Metrics please use ``Apache Tomcat`` integration since ``Tomcat NetWitness Logs`` integration will be deprecated soon.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have the Apache Tomcat integration published, we can provide the link to that integration here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but for now we have kept just name of the integration.

harnish-elastic
harnish-elastic approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ishleenk17
Copy link
Contributor

Looks good, but lets merge this PR once the Apache Tomcat Pr's are merged

ishleenk17
ishleenk17 approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but lets merge this PR once the Apache Tomcat PR's are merged.

lalit-satapathy
lalit-satapathy reviewed May 5, 2023
View reviewed changes
packages/tomcat/_dev/build/docs/README.md
@@ -1,10 +1,13 @@
# Tomcat integration
# Tomcat NetWitness Logs integration (To be deprecated soon)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we provide a link to the new integration to be used instead here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lalit-satapathy : Please refer to this comment

@lalit-satapathy lalit-satapathy mentioned this pull request May 5, 2023
Closed
17 tasks
@kush-elastic kush-elastic merged commit 4dbc372 into elastic:main May 7, 2023
1 check passed
@elasticmachine
Copy link

Package tomcat - 1.8.2 containing this change is available at https://epr.elastic.co/search?package=tomcat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalit-satapathy lalit-satapathy lalit-satapathy left review comments

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@harnish-elastic harnish-elastic harnish-elastic approved these changes

Assignees

@kush-elastic kush-elastic

Labels
enhancement New feature or request Integration:Tomcat Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@niraj-elastic @elasticmachine @ishleenk17 @lalit-satapathy @harnish-elastic @kush-elastic