Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tomcat] Update README.md #6124

Merged

Conversation

niraj-elastic
Copy link
Contributor

  • Deprecation

What does this PR do?.

  • Add link of new apache_tomcat package in README.md.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/tomcat) directory.
  • Run the following command to run tests. elastic-package test

Related issues

@niraj-elastic niraj-elastic requested a review from a team as a code owner May 9, 2023 06:47
@elasticmachine
Copy link

elasticmachine commented May 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-09T06:57:20.164+0000

  • Duration: 17 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.013
Classes 100.0% (1/1) 💚 3.013
Methods 77.778% (7/9) 👎 -14.008
Lines 82.143% (46/56) 👎 -9.942
Conditionals 100.0% (0/0) 💚

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kush-elastic kush-elastic merged commit 2894aa3 into elastic:main May 9, 2023
3 checks passed
@elasticmachine
Copy link

Package tomcat - 1.8.3 containing this change is available at https://epr.elastic.co/search?package=tomcat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Tomcat Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants