-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[elastic_agent] Agent Metrics Dashboard improvements #10031
Conversation
5b63498
to
17ca98b
Compare
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
@leehinman do you want to merge from upstream? The conflicts are probably me. Hoping I'll actually have time to get to this tomorrow. |
17ca98b
to
5ff8e0c
Compare
I didn't touch the "CPU Usage" chart, but I figured out what is wrong. It is the fact that the data view is set to "auto" and we only get events every minute. So if auto picks buckets that are smaller than one minute (which is what happens with default 15 min time picker) Some of the buckets have no data, and things like derivations don't work. :-( fix coming soon. |
@fearful-symmetry try it now |
@leehinman @pierrehilbert is this good to be merged? |
Marius is out on paternity leave, I added Joe Reuter as reviewer, I'd like someone with a bit more Dashboard experience to review just to make sure I'm not missing something. |
packages/elastic_agent/kibana/dashboard/elastic_agent-f47f18cc-9c7d-4278-b2ea-a6dee816d395.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Some comments.
I ran this on some sample data and the first chart errors out for me:
![Screenshot 2024-06-13 at 15 01 10](https://private-user-images.githubusercontent.com/1508364/339369227-31d89310-5e5d-4d4c-b3db-f23e99f1c957.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3NjIyMzQsIm5iZiI6MTcyNTc2MTkzNCwicGF0aCI6Ii8xNTA4MzY0LzMzOTM2OTIyNy0zMWQ4OTMxMC01ZTVkLTRkNGMtYjNkYi1mMjNlOTlmMWM5NTcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDhUMDIxODU0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTViNGQxZDBkMmE2MzQzMWIzY2EwMzFhZWZhMjc3NTQ4NTY3ZGQyODQwNGMyYTc0YmQ3OTkzMWRiZmFkZmM2YSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.wsHMSp8Y5x_9rylAY8_XfQmm_kQhwRD3qeNzy6rDkHA)
Didn't dig deeper on why that's happening, but it seems to be a TSVB vis, is there a reason for this? By my understanding we shouldn't use TSVB unless absolutely required.
In terms of the charts - all the time series charts are pretty dense and the y axis label doesn't really add much as the title is explaining it quite well already - I think we can omit them:
For the x axis, it's pretty much the same - IMHO we can just remove the label here, the "per minute" is more confusing than helpful as we normalize the value per second anyway:
Looks like this was done when Dashboards were first made. I'm going to leave it as TSVB until Marius bets back and we can ask him about it, since he did the original work. I think the error is "too much data", and I'm guessing that is because I set the interval to "1m", I switched it to ">=1m", lets see if that fixes it. If we go less than 1m, we have a different problem.
I didn't find a way to "remove" the text, I can change it to " ", so nothing shows up, but I can't seem to remove it totally and reclaim the space. Do you know of a better way?
These are automatically added, so I could remove the "@timestamp" part of "@timestamp per minute", but I didn't find a way to remove the "per minute" part. Any ideas? |
db7f9e6
to
a5492d8
Compare
@flash1293 Thanks for the help on the axis titles. 2 of the the panels are different and don't have those options, but I got it fixed on the rest. screenshot below. ![]() |
💚 Build Succeeded
History
|
|
yeah, for tsvb you can't remove it I think - LGTM from the dashboard side based on the screenshots |
Package elastic_agent - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=elastic_agent |
Proposed commit message
The visualizations in the "[Elastic Agent] Agent Metrics" Dashboard have been improved. Specifically:
For the following visualizations the breakdown was changed from
beat.type
toagent.name
+component.id
. This was necessary because it was grouping data together from different sources which was reporting incorrect values.agent.name
+component.id
is correct because this maps the data to the unique process id that generated the data.Also, the interval was changed from auto to minute. This is necessary because the data only comes in at 1 minute intervals. By default the visualization was grabbing smaller intervals which was breaking the visualization.
The following visualizations were added.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots
Before
After
All Visualization