Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snyk: allow dynamic organization look-up in audit_logs data stream #10073

Merged
merged 1 commit into from
Jul 16, 2024
Merged

snyk: allow dynamic organization look-up in audit_logs data stream #10073

merged 1 commit into from
Jul 16, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 5, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:snyk Snyk Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Jun 5, 2024
@efd6 efd6 self-assigned this Jun 5, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 force-pushed the 5360-snyk branch 2 times, most recently from cf4f578 to fd62f1b Compare June 12, 2024 21:39
@efd6 efd6 marked this pull request as ready for review July 2, 2024 08:39
@efd6 efd6 requested a review from a team as a code owner July 2, 2024 08:39
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

ShourieG
ShourieG approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@criamico criamico mentioned this pull request Jul 5, 2024
Open
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
54.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@narph narph requested a review from SpencerLN July 9, 2024 08:59
@efd6 efd6 merged commit b6e3b96 into elastic:main Jul 16, 2024
5 checks passed
@elasticmachine
Copy link

Package snyk - 1.25.0 containing this change is available at https://epr.elastic.co/search?package=snyk

tetianakravchenko pushed a commit to tetianakravchenko/integrations that referenced this pull request Jul 16, 2024
@efd6 @tetianakravchenko
snyk: allow dynamic organization look-up in audit_logs data stream (e…
bf79744 
…lastic#10073)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

@SpencerLN SpencerLN Awaiting requested review from SpencerLN

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:snyk Snyk Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Snyk] Support Dynamic Retrieval of Audit Logs for All Orgs
3 participants
@efd6 @elasticmachine @ShourieG