Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[okta] Make event.original optional #1009

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented May 19, 2021

What does this PR do?

Makes event.original optional in the same way as the rest of packages.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

Screenshots

image

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-05-26T22:28:35.568+0000

  • Duration: 11 min 40 sec

  • Commit: 30d0d05

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a small comment, and if you could bump ECS version as well it would be great.

packages/okta/data_stream/system/manifest.yml Show resolved Hide resolved
@marc-gr marc-gr merged commit e9b126c into elastic:master May 27, 2021
@marc-gr marc-gr deleted the okta-changes branch May 27, 2021 13:25
james-elastic pushed a commit to james-elastic/integrations that referenced this pull request Jun 30, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:okta Okta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants