Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus] add event.module and event.dataset #1249

Merged
merged 5 commits into from
Jun 30, 2021
Merged

[prometheus] add event.module and event.dataset #1249

merged 5 commits into from
Jun 30, 2021

Conversation

endorama
Copy link
Member

@endorama endorama commented Jun 30, 2021

What does this PR do?

Add event.module and event.dataset to all data streams in prometheus package.

From changes discussed in https://github.com/elastic/security-team/issues/780

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

I didn't run elastic-package test as I'm still setting up all the required environment.

Add `module.event` and `module.dataset` to all data streams in
prometheus package.

From changes discussed in
elastic/security-team#780
@endorama endorama added the Team:Integrations Label for the Integrations team label Jun 30, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@endorama endorama requested a review from mtojek June 30, 2021 08:46
@endorama endorama changed the title add module.event and module.dataset to prometheus package [prometheus] add module.event and module.dataset Jun 30, 2021
@elasticmachine
Copy link

elasticmachine commented Jun 30, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1249 updated

  • Start Time: 2021-06-30T09:26:31.074+0000

  • Duration: 11 min 31 sec

  • Commit: 84e42f1

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to bump up kibana version constraint:

conditions:
  kibana.version: "^7.14.0"

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "0.4.0"
changes:
- description: Set `module.event` and `module.dataset`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: event.module and event.dataset

nit: same in the PR description

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@endorama endorama changed the title [prometheus] add module.event and module.dataset [prometheus] add event.module and event.dataset Jun 30, 2021
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it, please!

@endorama endorama merged commit 847dccb into elastic:master Jun 30, 2021
@endorama endorama deleted the prometheus-event-module branch June 30, 2021 09:52
james-elastic pushed a commit to james-elastic/integrations that referenced this pull request Jun 30, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants