Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubernetes package ecs fields #1407

Merged
merged 8 commits into from
Aug 2, 2021
Merged

Update kubernetes package ecs fields #1407

merged 8 commits into from
Aug 2, 2021

Conversation

MichaelKatsoulis
Copy link
Contributor

What does this PR do?

This PR adds orchestrator.cluster.name and orchestrator.cluster.url ECS fields in Kubernetes
package

@MichaelKatsoulis MichaelKatsoulis added enhancement New feature or request Team:Integrations Label for the Integrations team labels Jul 30, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

elasticmachine commented Jul 30, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-02T10:06:36.259+0000

  • Duration: 28 min 4 sec

  • Commit: c625181

Test stats 🧪

Test Results
Failed 0
Passed 112
Skipped 0
Total 112

Trends 🧪

Image of Build Times

Image of Tests

@ChrsMark ChrsMark mentioned this pull request Aug 2, 2021
Merged
2 tasks
ChrsMark
ChrsMark approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing this!

Please resolve the conflicts and wfg before merging.

packages/kubernetes/_dev/build/build.yml
@@ -0,0 +1,3 @@
dependencies:
ecs:
reference: git@1.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@MichaelKatsoulis MichaelKatsoulis merged commit 41b736e into elastic:master Aug 2, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@MichaelKatsoulis
Update kubernetes package ecs fields (elastic#1407)
eb63a5f 
* Add orchestrator.cluster.name and orchestrator.cluster.url ecs fields in kubernetes package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelKatsoulis @elasticmachine @ChrsMark @mtojek