-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP] Add GCP Compute Metricset #2301
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
@endorama next one ready for your review |
c1b02b2
to
3948e06
Compare
@endorama Any thoughts on this one? |
Pinging @elastic/integrations (Team:Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Waiting for @endorama 's review 🙂
/test |
Sorry for the delay, I've been stuck adding tests to the |
@endorama updates pushed |
@legoguy1000 thanks! May you please check dashboards too? It seems those still contains old values. |
@endorama Dashboards should be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates! I see tests are still failing, but wasn't able to pin point the exact issue.
rerunning tests in case has been a transactional issue. /test |
I've been able to update the sample data and working on a PR in beats to update them. |
Cool, feel free to push that update to this branch or send it to me and I'll update it. |
@legoguy1000 I started working on updating the sample events in beats in the linked PR, but is taking longer than expected. In any case I've been able to update the |
e2554d4
to
c908ec2
Compare
c908ec2
to
32e57ee
Compare
@endorama looks like it worked. |
Thank you! I'm merging this as is good to go, I'll open a separate PR with testing for this data stream. @legoguy1000 next week I'll be off, so feel free to open the next PR but I won't be able to look at it before the 10th of January. Thank you for the contribution and happy new year! |
* gcp: stub logs and metrics doc files * [GCP] Add GCP Billing Metricset (#2141) * [GCP] Add GCP Compute Metricset (#2301) * [GCP] Add GCP Billing Metricset (#2141) * [GCP] Add GCP Compute Metricset (#2301) * Add firestore data_stream * Fix formatting issue * Add gcp tests env vars in Jenkinsfile * Add missing env fields * Update terraform deployer * Update system test * Fix credentials json field * Format & add period * Update docs * Update default period for firestoer * Update terraform deployer * Remove period from system test * Update manifest version * Update manifest file * Add default project id * Fix owner * Update audit docs * Fix terraform deployer * Remove redundant alternative host * Fix project variable * Remove default project string * Remove firestore datastream tests * Revert "Add gcp tests env vars in Jenkinsfile" This reverts commit ceea735. Co-authored-by: Edoardo Tenani <edoardo.tenani@elastic.co> Co-authored-by: Alex Resnick <adr8292@gmail.com>
What does this PR do?
Adds GCP Compute Metricset
Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).Author's Checklist
How to test this PR locally
Related issues
Screenshots