Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Okta integration #232

Merged
merged 5 commits into from
Aug 10, 2020
Merged

Add Okta integration #232

merged 5 commits into from
Aug 10, 2020

Conversation

andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Aug 5, 2020 •
edited
Loading

What does this PR do?

This adds a package for the filebeat Okta module.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Screenshots

Screen Shot 2020-08-05 at 1 38 41 PM

Screen Shot 2020-08-05 at 1 38 59 PM

Screen Shot 2020-08-05 at 1 39 12 PM

Screen Shot 2020-08-05 at 1 39 53 PM

Screen Shot 2020-08-06 at 9 49 28 AM

Screen Shot 2020-08-05 at 1 42 42 PM

Screen Shot 2020-08-05 at 2 31 33 PM

@andrewstucki andrewstucki added enhancement New feature or request Team:Integrations Label for the Integrations team Team:SIEM (Deprecated) labels Aug 5, 2020
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link

elasticmachine commented Aug 5, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #232 updated]

  • Start Time: 2020-08-10T16:05:29.528+0000

  • Duration: 3 min 10 sec

andrewkroh
andrewkroh reviewed Aug 6, 2020
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the screenshot it looks like both the httpjson and log input would be enabled by default. Is it possible to have only the httpjson input enabled by default?

packages/okta/manifest.yml Outdated Show resolved Hide resolved
leehinman
leehinman requested changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think error.message should be fixed, the others may or may not be really missing.

packages/okta/dataset/system/fields/ecs.yml Show resolved Hide resolved
packages/okta/docs/README.md Show resolved Hide resolved
packages/okta/docs/README.md Show resolved Hide resolved
@andrewstucki andrewstucki merged commit fb3124b into elastic:master Aug 10, 2020
@andrewstucki andrewstucki deleted the okta branch August 10, 2020 17:41
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Add Okta integration (elastic#232)
7f2a8dc 
* Add Okta integration

* hide some configuration fields

* set logs off by default

* Add error.message field

* Change webhook to API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh left review comments

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:okta Okta New Integration Team:Integrations Label for the Integrations team Team:SIEM (Deprecated)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewstucki @elasticmachine @andrewkroh @leehinman