[aws] Fix event.created in CloudTrail data stream #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
Pinging @elastic/integrations (Team:Integrations) |
andrewkroh
force-pushed
the
aws/fix-event-created-cloudtrail
branch
from
05fc437
to
96f4a70
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
andrewkroh
commented
Dec 9, 2021
| @@ -79,20 +78,6 @@ | |||
| }, | |||
| "version": "1.16.310" | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
The source file had extra newlines in it.
There was a problem hiding this comment.
That seems like something that shouldn't result in an output.
There was a problem hiding this comment.
I raised elastic/elastic-package#616 to catch these in elastic-package lint and format.
event.created was being set to the CloudTrail eventTime rather than the time that Filebeat created the document. Fixes elastic#2324
andrewkroh
force-pushed
the
aws/fix-event-created-cloudtrail
branch
from
96f4a70
to
a77a340
Compare
efd6
approved these changes
Dec 9, 2021
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
event.created was being set to the CloudTrail eventTime rather than the time that Filebeat created the document. Fixes elastic#2324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
event.created was being set to the CloudTrail eventTime rather than the time that Filebeat created the document.
Fixes #2324
Checklist
changelog.ymlfile.- [ ] I have verified that Kibana version constraints are current according to guidelines.Related issues