Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose event_id, and language options to all winlog inputs #2344

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Expose event_id, and language options to all winlog inputs #2344

merged 3 commits into from
Dec 16, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 15, 2021

What does this PR do?

  • Exposes the new language option for all integrations using the winlog input.
  • Exposes event_id for all integrations that didn't let the user customize this option.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@marc-gr marc-gr added enhancement New feature or request Team:Integrations Label for the Integrations team Team:Security-External Integrations labels Dec 15, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Dec 15, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-15T15:59:52.750+0000

  • Duration: 18 min 16 sec

  • Commit: 7fada81

Test stats 🧪

Test Results
Failed 0
Passed 401
Skipped 0
Total 401

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@marc-gr marc-gr merged commit 98889e0 into elastic:master Dec 16, 2021
@marc-gr marc-gr deleted the winlog-language branch December 16, 2021 12:38
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@marc-gr
Expose event_id, and language options to all winlog inputs (elastic#2344
5ead1dc 
)

* Expose event_id, and language options to all winlog inputs

* Add PR to the changelogs

* Fix language description link
@andrewkroh andrewkroh mentioned this pull request May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @efd6