[microsoft_dhcp] Add DHCPv6 support #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for ingesting logs from Microsoft DHCPv6 Server - Split pipeline into DHCPv4 and DHCPv6 handlers, switches on filename - Filter out header lines using filebeat processor - Add observer metadata using filebeat processor - Add pipeline and system tests
taylor-swanson
added
enhancement
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
reviewed
Jan 10, 2022
packages/microsoft_dhcp/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/microsoft_dhcp/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/microsoft_dhcp/data_stream/log/elasticsearch/ingest_pipeline/dhcp.yml
Show resolved
Hide resolved
packages/microsoft_dhcp/data_stream/log/elasticsearch/ingest_pipeline/dhcpv6.yml
Outdated
Show resolved
Hide resolved
packages/microsoft_dhcp/data_stream/log/elasticsearch/ingest_pipeline/dhcpv6.yml
Outdated
Show resolved
Hide resolved
… file - DHCP pipeline now uses similar method of assigning ECS fields like DHCPv6 - Added header lines to DHCP system test file - Switched event.action to string instead of array - Updated expected test result files
|
I also reworked the DHCP pipeline to use a similar method of setting ECS fields. It should be clearer now what event IDs are being enriched and it should also be easier moving forward to add more metadata as needed. One change I made was removing the |
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
- Add support for ingesting logs from Microsoft DHCPv6 Server - Split pipeline into DHCPv4 and DHCPv6 handlers, switches on filename - Filter out header lines using filebeat processor - Add observer metadata using filebeat processor - Add pipeline and system tests - DHCP pipeline now uses similar method of assigning ECS fields like DHCPv6 - Added header lines to DHCP system test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
changelog.ymlfile.How to test this PR locally
Related issues