Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package/network_traffic/tls: fix mapping for tls.detailed.server_certificate_chain #2517

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 12, 2022

What does this PR do?

This brings the mapping for server_certificate_chain into agreement with the packetbeat code and mapping, fixing #2499.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • The mapping for tls.server.certificate_chain in ECS disagrees with this change. I believe this is wrong based on the information required to describe a cert and that the packetbeat code marshals to a []common.MapStr. tls.server.certificate_chain is presumably intended to be filled with a string representation of the chain elements.

How to test this PR locally

elastic-package test system --data-streams tls in the network_traffic package.

Related issues

Screenshots

N/A

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jan 12, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-24T16:13:28.064+0000

  • Duration: 67 min 50 sec

  • Commit: cc73b5e

Test stats 🧪

Test Results
Failed 0
Passed 103
Skipped 0
Total 103

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 requested a review from a team January 12, 2022 23:17
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and matches Packetbeat's mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1-candidate bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network Packet Capture | TLS Parsing Error
3 participants