Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package/network_traffic/tls: fix mapping for tls.detailed.client_certificate_chain #2793

Merged
merged 1 commit into from
Mar 15, 2022
Merged

package/network_traffic/tls: fix mapping for tls.detailed.client_certificate_chain #2793

merged 1 commit into from
Mar 15, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 9, 2022 •
edited
Loading

What does this PR do?

This replays #2517 for client certificates, now fixing #2499.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 requested a review from a team as a code owner March 9, 2022 08:57
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 requested a review from andrewkroh March 9, 2022 08:58
@elasticmachine
Copy link

elasticmachine commented Mar 9, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-14T21:10:11.191+0000

  • Duration: 69 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 263
Skipped 0
Total 263

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

andrewkroh
andrewkroh approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, how do you obtain the updated sample_event.json files?

@efd6
Copy link
Contributor Author

efd6 commented Mar 15, 2022

I imagine that I used elastic-package test -v --data-streams tls -g (it's in my history and what I would expect to reach for).

@efd6 efd6 merged commit ef05f66 into elastic:main Mar 15, 2022
@efd6 efd6 deleted the tlsclient branch March 15, 2022 22:53
@andrewkroh andrewkroh mentioned this pull request Mar 22, 2022
Merged
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@efd6
package/network_traffic/tls: fix mapping for tls.detailed.client_cert…
e4244b0 
…ificate_chain (elastic#2793)
@andrewkroh andrewkroh mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
8.1-candidate 8.2-candidate bug Something isn't working, use only for issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network Packet Capture | TLS Parsing Error
3 participants
@efd6 @elasticmachine @andrewkroh