Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TI_Cybersixgill] Change from API to TAXII for the integration #2771

Merged
merged 5 commits into from
Mar 10, 2022
Merged

[TI_Cybersixgill] Change from API to TAXII for the integration #2771

merged 5 commits into from
Mar 10, 2022

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Mar 7, 2022 •
edited
Loading

What does this PR do?

The initial integration used to communicate with a third party python script, in collaboration with Cybersixgill we have converted this integration to rather use the TAXII server directly, this removes all third party tools requirements instead.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

The dashboards and fields are the same, but the ingest pipeline had to be rewritten to replace the functionality initially found in the python script

@P1llus P1llus requested a review from a team as a code owner March 7, 2022 13:50
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus
Copy link
Member Author

P1llus commented Mar 7, 2022

Awaiting feedback from Cybersixgill on a replacement for the Range header, to retrieve more items than the current default limit of 100.
Everything else is ready to be reviewed though.

@elasticmachine
Copy link

elasticmachine commented Mar 7, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-09T08:06:07.482Z&rangeTo=2022-03-09T08:26:07.482Z&transactionName=BUILD Ingest-manager/integrations/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=80376cdf04e0e636bc5ba90870479668&transactionId=dd603c688b325f58)

Expand to view the summary

Build stats

  • Start Time: 2022-03-09T08:16:07.482+0000

  • Duration: 13 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@P1llus
Copy link
Member Author

P1llus commented Mar 9, 2022

I have now tested this with 90 days worth of data working successfully, it is fully ready for review

efd6
efd6 reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need reformatting, check is complaining.

packages/ti_cybersixgill/_dev/build/docs/README.md Outdated Show resolved Hide resolved
@P1llus
Copy link
Member Author

P1llus commented Mar 9, 2022

I have a demo scheduled sometime tomorrow and will proceed with merging after that

@P1llus P1llus merged commit 7d43568 into elastic:main Mar 10, 2022
@andrewkroh andrewkroh mentioned this pull request Mar 14, 2022
Merged
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@P1llus
[TI_Cybersixgill] Change from API to TAXII for the integration (elast…
cafb39a 
…ic#2771)

* Changes Cybersixgill from http_endpoint to httpjson and using the TAXII Service

* update changelog

* changing typo in manifest icon

* adding pagination support

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
Integration:ti_cybersixgill Cybersixgill
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@P1llus @elasticmachine @efd6 @andrewkroh