Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import zoom module from Filebeat #284

Merged
merged 14 commits into from
Oct 2, 2020
Merged

Import zoom module from Filebeat #284

merged 14 commits into from
Oct 2, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Oct 1, 2020 •
edited
Loading

What does this PR do?

This imports the zoom module (webhook dataset) from Filebeat.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Author's Checklist

  • Categories are correct (main manifest.yml), currently security and productivity.

How to test this PR locally

You can send to it events from <beats>/x-pack/filebeat/module/zoom/webhook/test/*.log using an HTTP POST with Content-Type: application/json.

Screenshots

Screen Shot 2020-10-01 at 18 32 50

Screenshot_2020-10-01 Zoom - Integrations - Fleet - Elastic

Screenshot_2020-10-01 Add integration - Zoom - Integrations - Fleet - Elastic

@adriansr adriansr added the enhancement New feature or request label Oct 1, 2020
@elasticmachine
Copy link

elasticmachine commented Oct 1, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #284 updated]

  • Start Time: 2020-10-02T09:15:23.911+0000

  • Duration: 4 min 43 sec

andrewkroh
andrewkroh approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtojek mtojek self-requested a review October 2, 2020 06:27
mtojek
mtojek suggested changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the PR accordingly to changes introduced in #280 .

Main changes:

  1. Rebase against master.
  2. Rename "dataset" folder to "data_stream".
  3. Rename "config_templates" to "policy_templates" in package manifest file.

@andresrc andresrc added the Team:SIEM (Deprecated) label Oct 2, 2020
@elasticmachine
Copy link

Pinging @elastic/siem (Team:SIEM)

@adriansr adriansr merged commit 736c339 into elastic:master Oct 2, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@adriansr
Import zoom module from Filebeat (elastic#284)
6f19a22 
This adds the Zoom/0.1.0 integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek requested changes

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:zoom Zoom New Integration Team:SIEM (Deprecated)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adriansr @elasticmachine @andrewkroh @mtojek @andresrc