Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apache_spark][node] Change naming convention of the node data stream #3070

Merged
merged 7 commits into from
May 9, 2022
Merged

[apache_spark][node] Change naming convention of the node data stream #3070

merged 7 commits into from
May 9, 2022

Conversation

yug-rajani
Copy link
Contributor

@yug-rajani yug-rajani commented Apr 12, 2022 •
edited
Loading

What does this PR do?

  • Refactor the nodes data stream to adjust its name to singular (node) as per the discussion here.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/apache_spark directory.
  • Run the following command to run tests.

elastic-package test

@yug-rajani yug-rajani requested a review from a team as a code owner April 12, 2022 05:06
@yug-rajani yug-rajani changed the title Change naming convention of node datastream [apache_spark][node] Change naming convention of the node data stream Apr 12, 2022
@yug-rajani yug-rajani self-assigned this Apr 12, 2022
@yug-rajani yug-rajani added enhancement New feature or request Team:Integrations Label for the Integrations team labels Apr 12, 2022
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

elasticmachine commented Apr 12, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-03T09:15:11.568+0000

  • Duration: 17 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@yug-rajani yug-rajani mentioned this pull request Apr 12, 2022
Merged
4 tasks
mtojek
mtojek reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing. When you push updates to an already published package, please raise the manifest version :)

@mtojek mtojek self-requested a review April 12, 2022 07:42
mtojek
mtojek suggested changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes

@yug-rajani yug-rajani requested a review from mtojek April 12, 2022 09:28
@yug-rajani yug-rajani requested a review from mtojek April 12, 2022 13:24
@yug-rajani yug-rajani linked an issue Apr 26, 2022 that may be closed by this pull request
Create Apache Spark integration #493
Closed
16 tasks
jsoriano
jsoriano approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yug-rajani yug-rajani mentioned this pull request Apr 28, 2022
Closed
4 tasks
@elasticmachine
Copy link

elasticmachine commented Apr 28, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.275
Classes 100.0% (0/0) 💚 3.275
Methods 75.0% (12/16) 👎 -14.113
Lines 100.0% (0/0) 💚 10.01
Conditionals 100.0% (0/0) 💚

@mtojek mtojek merged commit 3323466 into elastic:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@ruflin ruflin ruflin approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@yug-rajani yug-rajani

Labels
enhancement New feature or request Integration:apache_spark Apache Spark Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Apache Spark integration
6 participants
@yug-rajani @elasticmachine @jsoriano @ruflin @mtojek @masci