Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Sophos readme #3160

Merged
merged 10 commits into from
Jun 16, 2022
Merged

update Sophos readme #3160

merged 10 commits into from
Jun 16, 2022

Conversation

ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 21, 2022

updated the readme file to include links to Sophos's documentation. Also used the latest product name for Astaro

Type of change

  • Enhancement

What does this PR do?

updated the readme file to include links to Sophos's documentation. Also used the latest product name for Astaro

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

updated the readme file to include links to Sophos's documentation.  Also used the latest product name for Astaro
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 21, 2022
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 21, 2022 10:32
@ellis-elastic ellis-elastic marked this pull request as draft April 21, 2022 10:32
@elasticmachine
Copy link

elasticmachine commented Apr 21, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-15T08:35:48.719+0000

  • Duration: 19 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ellis-elastic ellis-elastic marked this pull request as ready for review April 22, 2022 08:24
@elasticmachine
Copy link

elasticmachine commented Apr 27, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (13/13) 💚 3.432
Classes 100.0% (13/13) 💚 3.432
Methods 98.901% (90/91) 👍 9.569
Lines 94.432% (1747/1850) 👍 4.497
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a minor observation. Also there appears to be a version conflict (changelog.yml and manifest.yml).

packages/sophos/_dev/build/docs/README.md Outdated Show resolved Hide resolved
ellis-elastic and others added 3 commits June 9, 2022 14:22
Co-authored-by: Sai Kiran <85323324+r00tu53r@users.noreply.github.com>
drop the parenthetic as described earlier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants