Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cisco_umbrella] Fix dns logs populating destination.ip instead of source.nat.ip #3218

Merged
merged 1 commit into from
Apr 29, 2022
Merged

[cisco_umbrella] Fix dns logs populating destination.ip instead of source.nat.ip #3218

merged 1 commit into from
Apr 29, 2022

Conversation

adriansr
Copy link
Contributor

What does this PR do?

Changes the Cisco Umbrella ingest pipeline to populate the source.nat.ip field instead of destination.ip.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@adriansr adriansr requested a review from a team as a code owner April 28, 2022 15:07
@adriansr adriansr added bug Something isn't working, use only for issues Integration:cisco_umbrella Cisco Umbrella labels Apr 28, 2022
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-28T15:07:42.954+0000

  • Duration: 16 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 5.797
Classes 100.0% (1/1) 💚 5.797
Methods 93.75% (15/16) 👍 6.43
Lines 94.408% (287/304) 👍 4.684
Conditionals 100.0% (0/0) 💚

@adriansr adriansr merged commit 63c1cc1 into elastic:main Apr 29, 2022
@andrewkroh andrewkroh mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:cisco_umbrella Cisco Umbrella
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriansr @elasticmachine @P1llus