-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration required for cloudbeat logs, metrics #3378
Add configuration required for cloudbeat logs, metrics #3378
Conversation
135478c
to
5b11968
Compare
🌐 Coverage report
|
@@ -0,0 +1,14 @@ | |||
- external: ecs | |||
name: ecs.version | |||
- name: log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.level
is an ECS field and can be specified more concisely as
- external: ecs
name: log.level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is message
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, but not too sure if it's correct.
ignore_above: 1024 | ||
description: Elastic Agent id. | ||
- name: process | ||
level: extended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
level
and example
are not attributes that are honored by package-spec
1. Currently they are allowed by our validation, but they serve no purpose and should not be included.
Footnotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed those attributes from all the files.
94ab549
to
5bbf554
Compare
5bbf554
to
bd6822f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, @elastic/elastic-agent-control-plane Please have another eye on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What does this PR do?
Required configuration changes to avoid permission errors when Agent-managed filebeat tries to create the
logs-elastic_agent.cloudbeat-*
index on ES.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Build the
elastic_agent
andcloud_security_posture
packages, bring the stack up along with the associated changes on Kibana. Running an Agent with the CIS integration added should show the option for cloudbeat logs on the logs page, as shown in the screenshot.Screenshots