checkpoint: fix handling of R81 fields #3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
r00tu53r
reviewed
Jul 22, 2022
Comment on lines
+474
to
480
| - convert: | ||
| field: checkpoint.bytes | ||
| type: long | ||
| ignore_missing: true | ||
| - rename: | ||
| field: checkpoint.bytes | ||
| target_field: network.bytes |
There was a problem hiding this comment.
Thinking of doing this in a single step -
Suggested change
| - convert: | |
| field: checkpoint.bytes | |
| type: long | |
| ignore_missing: true | |
| - rename: | |
| field: checkpoint.bytes | |
| target_field: network.bytes | |
| - convert: | |
| field: checkpoint.bytes | |
| target_field: network.bytes | |
| type: long | |
| ignore_missing: true |
There was a problem hiding this comment.
That leaves the value in checkpoint.bytes.
Comment on lines
+515
to
521
| - convert: | ||
| field: checkpoint.packets | ||
| type: long | ||
| ignore_missing: true | ||
| - rename: | ||
| field: checkpoint.packets | ||
| target_field: network.packets |
There was a problem hiding this comment.
Thinking of doing this in a single step -
Suggested change
| - convert: | |
| field: checkpoint.packets | |
| type: long | |
| ignore_missing: true | |
| - rename: | |
| field: checkpoint.packets | |
| target_field: network.packets | |
| - convert: | |
| field: checkpoint.packets | |
| type: long | |
| target_field: network.packets | |
| ignore_missing: true |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes handling of numeric and duplicated fields and removes undocumented fields that appear to be new in R81.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots