Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move lightweight manifest to integration for EBS data stream #3856

Merged
merged 10 commits into from
Aug 4, 2022
Merged

Move lightweight manifest to integration for EBS data stream #3856

merged 10 commits into from
Aug 4, 2022

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Jul 27, 2022

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@sayden sayden added the enhancement New feature or request label Jul 27, 2022
@sayden sayden requested a review from a team as a code owner July 27, 2022 10:08
@sayden sayden self-assigned this Jul 27, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 27, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-04T14:08:02.934+0000

  • Duration: 40 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 346
Skipped 0
Total 346

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -5.46
Classes 91.667% (11/12) 👎 -5.46
Methods 82.243% (176/214) 👎 -7.027
Lines 92.894% (2157/2322) 👍 2.241
Conditionals 100.0% (0/0) 💚

kaiyan-sheng
kaiyan-sheng reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metricsets: ["ebs"] should be metricsets: ["cloudwatch"] in stream.yml.hbs file. Also could you run this integration locally and copy paste an event from ES to update the sample_event.json please? TIA!!

kaiyan-sheng
kaiyan-sheng reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry one more: '*.metrics.*.*' should be removed from package-fields.yml file since we listed individual fields in the fields.yml already.

@sayden
Copy link
Contributor Author

sayden commented Jul 27, 2022

Sorry one more: '*.metrics.*.*' should be removed from package-fields.yml file since we listed individual fields in the fields.yml already.

I actually had this question about this one, great. Thanks!

@tommyers-elastic
Copy link
Contributor

@sayden can we get the CI green on this and get it merged?

@sayden
Copy link
Contributor Author

sayden commented Aug 4, 2022

@sayden can we get the CI green on this and get it merged?

Yes, please 😄

@sayden sayden merged commit 8cb3210 into elastic:main Aug 4, 2022
@sayden sayden deleted the aws/remove-lm/ebs branch August 4, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng left review comments

@girodav girodav girodav approved these changes

Assignees

@sayden sayden

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove lightweight modules from aws ebs data stream
5 participants
@sayden @elasticmachine @tommyers-elastic @girodav @kaiyan-sheng