-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move lightweight manifest to integration for EBS data stream #3856
Conversation
# Conflicts: # packages/aws/changelog.yml
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metricsets: ["ebs"]
should be metricsets: ["cloudwatch"]
in stream.yml.hbs file. Also could you run this integration locally and copy paste an event from ES to update the sample_event.json please? TIA!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry one more: '*.metrics.*.*'
should be removed from package-fields.yml file since we listed individual fields in the fields.yml already.
I actually had this question about this one, great. Thanks! |
# Conflicts: # packages/aws/changelog.yml # packages/aws/manifest.yml
@sayden can we get the CI green on this and get it merged? |
Yes, please 😄 |
Checklist
changelog.yml
file.Related issues