-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Update sample_event.json for kinesis data stream #3874
Conversation
🌐 Coverage report
|
@@ -5,52 +5,6 @@ | |||
footnote: 'Examples: If Metricbeat is running on an EC2 host and fetches data from its host, the cloud info contains the data about this machine. If Metricbeat runs on a remote machine outside the cloud and fetches data from a service running in the cloud, the field contains cloud data from the machine the service is running on.' | |||
type: group | |||
fields: | |||
- name: account.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fields are all from ECS, that's why I'm removing them into the ecs.yml file. I wonder if we should have a meta PR for doing the same thing for other data streams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this ! sounds like removing ECS fields from agent.yml across all integrations is a good idea, but don't worry about it right now. it doesn't have much impact AFAICT. i'll put something on the backlog that we can think about later.
What does this PR do?
This PR is to update the sample_event.json file for kinesis data stream.
Checklist
changelog.yml
file.