Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Update sample_event.json for kinesis data stream #3874

Merged
merged 3 commits into from
Jul 28, 2022
Merged

[AWS] Update sample_event.json for kinesis data stream #3874

merged 3 commits into from
Jul 28, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 27, 2022

What does this PR do?

This PR is to update the sample_event.json file for kinesis data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner July 27, 2022 22:27
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 27, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-28T12:02:59.216+0000

  • Duration: 41 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 346
Skipped 0
Total 346

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 27, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -5.465
Classes 91.667% (11/12) 👎 -5.465
Methods 82.243% (176/214) 👎 -7.008
Lines 92.894% (2157/2322) 👍 2.293
Conditionals 100.0% (0/0) 💚

@@ -5,52 +5,6 @@
footnote: 'Examples: If Metricbeat is running on an EC2 host and fetches data from its host, the cloud info contains the data about this machine. If Metricbeat runs on a remote machine outside the cloud and fetches data from a service running in the cloud, the field contains cloud data from the machine the service is running on.'
type: group
fields:
- name: account.id
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields are all from ECS, that's why I'm removing them into the ecs.yml file. I wonder if we should have a meta PR for doing the same thing for other data streams.

@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Jul 28, 2022
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this ! sounds like removing ECS fields from agent.yml across all integrations is a good idea, but don't worry about it right now. it doesn't have much impact AFAICT. i'll put something on the backlog that we can think about later.

@kaiyan-sheng kaiyan-sheng merged commit 711f246 into elastic:main Jul 28, 2022
@kaiyan-sheng kaiyan-sheng deleted the aws_kinesis branch July 28, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants