Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infoblox_nios] Added Support for new type of DHCP logs #3883

Merged
merged 5 commits into from
Aug 16, 2022

Conversation

vinit-chauhan
Copy link
Contributor

@vinit-chauhan vinit-chauhan commented Jul 28, 2022

Type of change

  • Enhancement

What does this PR do?

This PR adds support for parsing DHCPOFFER & DHCPACK logs from the ISC DHCP process and additional Support for parsing Encapsulated Solicit, Advertise NA, Encapsulating Advertise, Sending Relay-reply, Relay-forward logs from the ISC dhcpv6 Process.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Screenshots

image
image
image

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jul 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-14T19:23:17.201+0000

  • Duration: 17 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 35
Skipped 0
Total 35

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 28, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 2.896
Classes 100.0% (4/4) 💚 2.896
Methods 97.297% (36/37) 👍 8.208
Lines 98.918% (457/462) 👍 7.367
Conditionals 100.0% (0/0) 💚

@andrewkroh
Copy link
Member

This PR adds support for a new type of DHCP logs.

Please be more descriptive. What's the new type? Is this adding support for parsing addition ISC dhcp log message formats? Is it adding support for parsing logs from the ISC dhcpv6 process? Etc.

packages/infoblox_nios/changelog.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants