Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Citrix ADC] Add Integration Package with Interface Data Stream #4322

Merged

Conversation

harnish-crest
Copy link
Contributor

@harnish-crest harnish-crest commented Sep 27, 2022

  • Enhancement

What does this PR do?

  • Added 1 data stream (Interface metrics).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/citrix_adc) directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

citrix_adc-overview-dashboard
new-interface-dashboard

@harnish-crest harnish-crest marked this pull request as draft September 27, 2022 13:10
@elasticmachine
Copy link

elasticmachine commented Sep 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-02T11:23:14.046+0000

  • Duration: 16 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@yug-rajani
Copy link
Contributor

/test

1 similar comment
@kush-elastic
Copy link
Collaborator

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Sep 27, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.703
Classes 100.0% (1/1) 💚 2.703
Methods 100.0% (9/9) 💚 9.14
Lines 98.047% (251/256) 👍 6.459
Conditionals 100.0% (0/0) 💚

@harnish-crest harnish-crest marked this pull request as ready for review September 28, 2022 04:52
@yug-rajani yug-rajani added enhancement New feature or request Integration:Citrix-Netscaler Team:Service-Integrations Label for the Service Integrations team labels Sep 28, 2022
@yug-rajani yug-rajani linked an issue Sep 28, 2022 that may be closed by this pull request
5 tasks
@muthu-mps muthu-mps self-requested a review September 28, 2022 10:49
@muthu-mps
Copy link
Contributor

Please remove ibmmq in the How to test this PR instructions

@muthu-mps
Copy link
Contributor

Can we add new visualisation's that would show the received, transmitted bytes and dropped inbound, outbound packets over the period of time ?

@muthu-mps
Copy link
Contributor

Can we remove the Value of from the visualisation names for Received and Transmitted Bytes ?

@harnish-crest
Copy link
Contributor Author

harnish-crest commented Nov 1, 2022

Can we remove the Value of from the visualisation names for Received and Transmitted Bytes ?

Makes sense. We will be removing number of and value of from the titles of all the visualization, and following will be updated titles for all the visualizations,

  • Outbound Packets Dropped by Hardware over time
  • Inbound Packets Dropped over time
  • Received Bytes over time
  • Transmitted Bytes over time

Please let me know if there are any other changes related to dashboard which needs to be updated, so we can reduce this back and forth.

@muthu-mps
Copy link
Contributor

Can we remove the Value of from the visualisation names for Received and Transmitted Bytes ?

Makes sense. We will be removing number of and value of from the titles of all the visualization, and following will be updated titles for all the visualizations,

  • Outbound Packets Dropped by Hardware over time
  • Inbound Packets Dropped over time
  • Received Bytes over time
  • Transmitted Bytes over time

Please let me know if there are any other changes related to dashboard which needs to be updated, so we can reduce this back and forth.

@harnish-crest - I would recommend to check the visualisation names with other visualisations as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create package to monitor server workers using Citrix ADC (Netscaler)
5 participants