Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Citrix ADC] Add Integration Package with lbvserver Data Stream #4418

Merged
merged 10 commits into from
Dec 7, 2022
Merged

[Citrix ADC] Add Integration Package with lbvserver Data Stream #4418

merged 10 commits into from
Dec 7, 2022

Conversation

harnish-crest
Copy link
Contributor

@harnish-crest harnish-crest commented Oct 7, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

  • Added 1 data stream (lbvserver metrics).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/citrix_adc directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

citrix_adc-lbvserver-dashboard
citrix_adc-overview-dashboard

@harnish-crest harnish-crest marked this pull request as draft October 7, 2022 11:47
This was referenced Oct 7, 2022
Merged
Merged
@elasticmachine
Copy link

elasticmachine commented Oct 7, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-28T10:23:56.760+0000

  • Duration: 15 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic
Copy link
Collaborator

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Oct 7, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (29/29) 💚 1.961
Lines 97.902% (700/715) 👍 2.116
Conditionals 100.0% (0/0) 💚

@muthu-mps muthu-mps self-requested a review October 10, 2022 09:42
@kush-elastic
Copy link
Collaborator

/test

This was referenced Oct 13, 2022
Merged
Merged
@muthu-mps muthu-mps mentioned this pull request Nov 11, 2022
Closed
5 tasks
@muthu-mps
Copy link
Contributor

closes #3746

@kush-elastic kush-elastic added enhancement New feature or request Integration:Citrix-Netscaler Team:Service-Integrations Label for the Service Integrations team labels Nov 11, 2022
@harnish-crest harnish-crest marked this pull request as ready for review November 22, 2022 10:31
@harnish-crest harnish-crest requested a review from a team as a code owner November 22, 2022 10:31
muthu-mps
muthu-mps reviewed Nov 25, 2022
View reviewed changes
packages/citrix_adc/data_stream/lbvserver/fields/fields.yml Outdated Show resolved Hide resolved
packages/citrix_adc/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/citrix_adc/data_stream/lbvserver/fields/fields.yml
- name: down.backup.hits
type: float
description: Number of times traffic was diverted to the backup vserver since the primary vserver was DOWN.
metric_type: counter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a gauge value ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muthu-mps, this field is containing the value of total backup server hits. Based on our understanding total backup hits won't get fluctuate it will only increase, it could get only reset on some unexpected scenarios but won't fluctuate. It should be consider as counter.

@muthu-mps
Copy link
Contributor

Can we remove the over the time in the Visualisation names ?

@harnish-crest
Copy link
Contributor Author

Can we remove the over the time in the Visualisation names ?

We generally follows this practice when it is a line chart. If we remove the over time from the title then it doesn't look compact. For example, title for the Spillovers over time, if we remove over time here then it would be moreover like Spillovers only. instead of that Spillovers over time give the sense that this dashboards is showing Spillovers against the time.

@harnish-crest harnish-crest requested review from muthu-mps and removed request for lalit-satapathy December 1, 2022 09:26
muthu-mps
muthu-mps approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit d67a7e5 into elastic:main Dec 7, 2022
@elasticmachine
Copy link

Package citrix_adc - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=citrix_adc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kush-elastic kush-elastic kush-elastic approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees

@harnish-crest harnish-crest

Labels
enhancement New feature or request Integration:Citrix-Netscaler Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harnish-crest @elasticmachine @kush-elastic @muthu-mps