Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Add compute ingest pipeline #4343

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Sep 29, 2022

What does this PR do?

Adds compute data stream ingest pipeline.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Sep 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-30T10:08:23.710+0000

  • Duration: 19 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 82
Skipped 0
Total 82

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 29, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.792
Classes 100.0% (5/5) 💚 2.792
Methods 90.816% (89/98) 👍 1.222
Lines 95.752% (1375/1436) 👍 4.217
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

elasticmachine commented Sep 29, 2022

🚀 Benchmarks report

Package gcp 👍(0) 💚(0) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 1915.71 1584.79 -330.92 (-17.27%) 💔
dns 2739.73 2044.99 -694.74 (-25.36%) 💔
firewall 3174.6 1792.11 -1382.49 (-43.55%) 💔
loadbalancing_logs 4878.05 3610.11 -1267.94 (-25.99%) 💔
vpcflow 4166.67 2283.11 -1883.56 (-45.21%) 💔

To see the full report comment with /test benchmark fullreport

@gpop63 gpop63 force-pushed the add_gcp-compute_ingest-pipeline branch from 0d84c8e to 6145c4d Compare September 29, 2022 15:15
@gpop63 gpop63 self-assigned this Sep 29, 2022
@gpop63 gpop63 marked this pull request as ready for review September 29, 2022 16:42
@gpop63 gpop63 requested review from a team as code owners September 29, 2022 16:42
@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Sep 30, 2022
@endorama endorama force-pushed the add_gcp-compute_ingest-pipeline branch from 97a5893 to 2a47e76 Compare September 30, 2022 10:08
Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and confirmed data points arrive under gcp.compute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcp.compute data stream does not collect data in correct namespace
3 participants