-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp,google_workspace: remove duplicate fields #4397
Conversation
3eec74e
to
b132bfb
Compare
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
audit |
1633.99 | 1360.54 | -273.45 (-16.74%) | 💔 |
Package google_workspace
👍(4) 💚(1) 💔(1)
Expand to view
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
groups |
5649.72 | 3496.5 | -2153.22 (-38.11%) | 💔 |
To see the full report comment with /test benchmark fullreport
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a grep for the fields & TBH I'm not 100% clear which ones should go and which not as I'm not familiar with this integration so I'll trust you on that as the formatting looks fine. LGTM
In general I'm choosing the ECS external definitions unless there is a local value being assigned to the field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcp changes LGTM. thanks!
What does this PR do?
This fixes field definition duplications in gcp and google_workspace.
elastic-package check
and are stochastic.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots