Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ForgeRock integration #4416

Merged
merged 74 commits into from
Jan 12, 2023
Merged

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Oct 6, 2022

What does this PR do?

Adds a new integration for ForgeRock Identity Platform.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Note

I've reworked this integration from when I initially put it out for review. I now have individual data streams for each source from ForgeRock, and have fixed the issues I had with paging.

How to test this PR locally

Below is a link to a development config and a postman collection for the API.

https://drive.google.com/file/d/1EZht-ycUrG6rp2PmswXgiUPhJFdMdJS9/view?usp=share_link

Related issues

Closes #1085

Screenshots

Screen Shot 2022-12-19 at 10 33 00 AM

Demo

https://drive.google.com/file/d/1F8WjLBLLMOromoTtX2wsLm-s4IrPDszd/view?usp=sharing

@elasticmachine
Copy link

elasticmachine commented Oct 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-11T18:02:40.013+0000

  • Duration: 23 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 56
Skipped 0
Total 56

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 31, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 100.0% (11/11) 💚
Classes 100.0% (11/11) 💚
Methods 100.0% (101/101) 💚 75.0
Lines 96.489% (962/997) 👎 -3.511
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@kgeller
Copy link
Contributor Author

kgeller commented Dec 13, 2022

/test

@kgeller kgeller marked this pull request as ready for review December 20, 2022 17:36
@kgeller kgeller requested a review from a team December 20, 2022 17:37
@kgeller kgeller requested a review from efd6 January 3, 2023 21:37
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looking through everything, but a couple of quick comments.

Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make the change for GA in the manifest, but otherwise LGTM.

packages/forgerock/manifest.yml Show resolved Hide resolved
@taylor-swanson
Copy link
Contributor

One other thing I noticed, the exported fields section in Kibana is showing "no fields available". I'm not sure if that's an issue with my kibana or how I built it, but seems odd that's missing.

Screen Shot 2023-01-11 at 9 56 17 AM

@kgeller
Copy link
Contributor Author

kgeller commented Jan 11, 2023

One other thing I noticed, the exported fields section in Kibana is showing "no fields available". I'm not sure if that's an issue with my kibana or how I built it, but seems odd that's missing.

Oh good catch! I forgot to update these after switching from one datastream to individual. Should be updated now.

@kgeller kgeller merged commit a62e66c into elastic:main Jan 12, 2023
@kgeller kgeller deleted the create-forgerock-int branch January 12, 2023 18:57
@elasticmachine
Copy link

Package forgerock - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=forgerock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request New Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ForgeRock Identity Platform
6 participants