-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ForgeRock integration #4416
Conversation
🌐 Coverage report
|
🚀 Benchmarks reportTo see the full report comment with |
…iting added, other fixes
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looking through everything, but a couple of quick comments.
packages/forgerock/data_stream/am_access/_dev/test/pipeline/test-am-access.log-expected.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make the change for GA in the manifest, but otherwise LGTM.
Oh good catch! I forgot to update these after switching from one datastream to individual. Should be updated now. |
Package forgerock - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=forgerock |
What does this PR do?
Adds a new integration for ForgeRock Identity Platform.
Checklist
changelog.yml
file.Author's Note
I've reworked this integration from when I initially put it out for review. I now have individual data streams for each source from ForgeRock, and have fixed the issues I had with paging.
How to test this PR locally
Below is a link to a development config and a postman collection for the API.
https://drive.google.com/file/d/1EZht-ycUrG6rp2PmswXgiUPhJFdMdJS9/view?usp=share_link
Related issues
Closes #1085
Screenshots
Demo
https://drive.google.com/file/d/1F8WjLBLLMOromoTtX2wsLm-s4IrPDszd/view?usp=sharing