Add new cluster name to ecs schema #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
kfirpeled
requested changes
Oct 18, 2022
| @@ -30,7 +30,8 @@ fetchers: | |||
| ] | |||
| processors: | |||
| - add_cluster_id: ~ | |||
| - add_environment_metadata: ~ | |||
There was a problem hiding this comment.
isn't the processor name been changed? add_orchestrator_metadata
There was a problem hiding this comment.
another question, why don't we use the same processor for eks as well?
kfirpeled
reviewed
Oct 18, 2022
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.0.2" | |||
| changes: | |||
| - description: Add cluster name to the ecs schema and enabling the relevant processor in the eks hbs file. | |||
There was a problem hiding this comment.
the description points to eks hbs file but the change was in vanilla hbs file.
kfirpeled
reviewed
Oct 19, 2022
| @@ -1,7 +1,12 @@ | |||
| # newer versions go on top | |||
| - version: "1.0.4" | |||
| changes: | |||
| - description: Add cluster name to the ecs schema. | |||
There was a problem hiding this comment.
nit: I think a clearer description would be, Updated mapping to include orchastrator.cluster.name or Added mapping to orchastrator.cluster.name
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
orchestrator.cluster.namefield to the ECS schema and enables the new Cloudbeat processor so Cloudbeat will fetch the cluster name along with each finding.This version will only support Kubernetes Vanilla, we will add support in EKS in a different PR.
Checklist
changelog.ymlfile.Related issues