-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new cluster name to ecs schema #4454
Add new cluster name to ecs schema #4454
Conversation
🌐 Coverage report
|
@@ -30,7 +30,8 @@ fetchers: | |||
] | |||
processors: | |||
- add_cluster_id: ~ | |||
- add_environment_metadata: ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the processor name been changed? add_orchestrator_metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another question, why don't we use the same processor for eks as well?
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "1.0.2" | |||
changes: | |||
- description: Add cluster name to the ecs schema and enabling the relevant processor in the eks hbs file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the description points to eks hbs file but the change was in vanilla hbs file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -1,7 +1,12 @@ | |||
# newer versions go on top | |||
- version: "1.0.4" | |||
changes: | |||
- description: Add cluster name to the ecs schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think a clearer description would be, Updated mapping to include orchastrator.cluster.name
or Added mapping to orchastrator.cluster.name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NP
What does this PR do?
This PR adds the
orchestrator.cluster.name
field to the ECS schema and enables the new Cloudbeat processor so Cloudbeat will fetch the cluster name along with each finding.This version will only support Kubernetes Vanilla, we will add support in EKS in a different PR.
Checklist
changelog.yml
file.Related issues