Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure_metrics] add compute_vm_scaleset pipeline test #4513

Merged
merged 4 commits into from
Nov 2, 2022
Merged

[azure_metrics] add compute_vm_scaleset pipeline test #4513

merged 4 commits into from
Nov 2, 2022

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Oct 27, 2022

What does this PR do?

Adds compute_vm_scaleset pipeline test.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Oct 27, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-02T15:03:28.296+0000

  • Duration: 14 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 133
Skipped 0
Total 133

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@gpop63 gpop63 force-pushed the add_compute-vm-scaleset_pipeline_test branch from 132166c to 8ec8e09 Compare October 27, 2022 21:20
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Oct 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.525
Classes 100.0% (2/2) 💚 2.525
Methods 71.429% (20/28) 👎 -19.302
Lines 100.0% (14/14) 💚 8.496
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review October 28, 2022 11:39
@gpop63 gpop63 requested a review from a team as a code owner October 28, 2022 11:39
@gpop63 gpop63 added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Oct 28, 2022
zmoog
zmoog reviewed Oct 28, 2022
View reviewed changes
packages/azure_metrics/changelog.yml Outdated
@@ -1,3 +1,8 @@
- version: "1.1.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we bumping the patch version here, while on #4512 we are bumping the minor version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought we would merge #4512 first, then this one. I fixed and bumped patch versions in both PRs.

zmoog
zmoog approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gpop63 gpop63 merged commit dd312c5 into elastic:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

Assignees
No one assigned
Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[azure_metrics] add pipeline tests for compute_vm_scaleset data stream
3 participants
@gpop63 @elasticmachine @zmoog