-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] [Cisco Duo] Make enhancement in connector with best practices implementation #4557
Conversation
…o the date and convert processors
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🌐 Coverage report
|
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
admin |
7194.24 | 3759.4 | -3434.84 (-47.74%) | 💔 |
auth |
2145.92 | 1414.43 | -731.49 (-34.09%) | 💔 |
offline_enrollment |
28571.43 | 18867.92 | -9703.51 (-33.96%) | 💔 |
summary |
40000 | 31250 | -8750 (-21.88%) | 💔 |
To see the full report comment with /test benchmark fullreport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue I see here is the large amount of ignore_failures
which has to be removed, as we do not really use them unless necessary in our ingest pipelines.
packages/cisco_duo/changelog.yml
Outdated
@@ -1,115 +1,120 @@ | |||
# newer versions go on top | |||
- version: "1.6.0" | |||
- version: '1.6.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the dashboard changes etc, feel free to bump this to 1.7.0
packages/cisco_duo/changelog.yml
Outdated
changes: | ||
- description: Update package to ECS 8.5.0. | ||
type: enhancement | ||
link: https://github.com/elastic/integrations/pull/4285 | ||
- version: "1.5.2" | ||
- version: '1.5.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to change these to double quotes, just so it matches all other integrations
field: message | ||
copy_from: json.description | ||
if: ctx?.json?.description != null | ||
if: ctx.json?.description != null | ||
ignore_failure: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of ignore_failures
here, which we don't really use in our ingest pipelines unless absolutely necessary, is there any specific reason so many was added?
packages/cisco_duo/manifest.yml
Outdated
@@ -1,7 +1,7 @@ | |||
format_version: 1.0.0 | |||
name: cisco_duo | |||
title: Cisco Duo | |||
version: "1.6.0" | |||
version: '1.6.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double quotes
Type of change
What does this PR do?
Make enhancement in Cisco Duo connector with listed best practices.
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshots