Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP-FPM] Add Integration Package with Process Data Stream #4652

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

harnish-crest
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Added 1 data stream (Process metrics).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to (integrations/packages/php_fpm) directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

php_fpm-process-dashboard

@elasticmachine
Copy link

elasticmachine commented Nov 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-24T11:26:42.513+0000

  • Duration: 15 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic
Copy link
Collaborator

/test

@kush-elastic kush-elastic self-requested a review November 15, 2022 17:08
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 15, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.314
Classes 100.0% (2/2) 💚 2.314
Methods 100.0% (16/16) 💚 8.754
Lines 95.763% (226/236) 👍 4.012
Conditionals 100.0% (0/0) 💚

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-crest harnish-crest marked this pull request as ready for review November 24, 2022 11:30
@harnish-crest harnish-crest requested a review from a team as a code owner November 24, 2022 11:30
@kush-elastic kush-elastic merged commit 028ad08 into elastic:main Dec 1, 2022
@elasticmachine
Copy link

Package php_fpm - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=php_fpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:php-fpm Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants