Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Add run_from property #4673

Merged
merged 4 commits into from
Nov 17, 2022
Merged

[Synthetics] Add run_from property #4673

merged 4 commits into from
Nov 17, 2022

Conversation

shahzad31
Copy link
Contributor

Add run_from property field as mentioned in elastic/kibana#140564

@shahzad31 shahzad31 requested a review from a team as a code owner November 17, 2022 13:42
emilioalvap
emilioalvap approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

elasticmachine commented Nov 17, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-17T13:50:21.116+0000

  • Duration: 13 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.318
Classes 100.0% (0/0) 💚 2.318
Methods 33.333% (6/18) 👎 -57.928
Lines 100.0% (0/0) 💚 8.289
Conditionals 100.0% (0/0) 💚

@shahzad31 shahzad31 merged commit 62a0193 into main Nov 17, 2022
@shahzad31 shahzad31 deleted the run-from branch November 17, 2022 14:10
@dominiqueclarke dominiqueclarke mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilioalvap emilioalvap emilioalvap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahzad31 @elasticmachine @emilioalvap