Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update screenshots and icon #4682

Merged
merged 9 commits into from
Nov 23, 2022
Merged

Update screenshots and icon #4682

merged 9 commits into from
Nov 23, 2022

Conversation

orouz
Copy link
Contributor

@orouz orouz commented Nov 20, 2022 •
edited
Loading

What does this PR do?

Updates screenshots and icon

Checklist

  • I have added an entry to my package's changelog.yml file.

Author's Checklist

How to test this PR locally

  • checkout branch
  • build package with elastic-package and run package-registry service
  • run local kibana

Screenshots

  • Search
    Screen Shot 2022-11-23 at 17 12 31

  • Integration
    Screen Shot 2022-11-23 at 17 12 17

@orouz orouz added the Team:Cloud Security Label for the Cloud Security team label Nov 20, 2022
@elasticmachine
Copy link

elasticmachine commented Nov 20, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-23T15:13:56.676+0000

  • Duration: 13 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@orouz orouz linked an issue Nov 20, 2022 that may be closed by this pull request
Update KSPM Screenshots #4341
Closed
@elasticmachine
Copy link

elasticmachine commented Nov 20, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (1/4) ❕
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@orouz orouz changed the title Update screenshots Update screenshots and icon Nov 20, 2022
@orouz orouz marked this pull request as ready for review November 22, 2022 15:02
@orouz orouz requested a review from a team as a code owner November 22, 2022 15:02
@orouz orouz requested a review from kfirpeled November 22, 2022 15:02
@tinnytintin10
Copy link
Contributor

@r4zr32d3k1l @orouz explained the technical reasons why we went with this design as opposed to the one from our mocks. I don't like this version of the design. Can you help devise a better alternative keeping in mind the sizing issues Or points out?

@orouz
Copy link
Contributor Author

orouz commented Nov 22, 2022

icon changed to remove whitespace and prevent this:
Screen Shot 2022-11-21 at 20 31 40

kfirpeled
kfirpeled approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orouz orouz merged commit 0a2b3f8 into elastic:main Nov 23, 2022
@elasticmachine
Copy link

Package cloud_security_posture - 1.0.8 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled approved these changes

Assignees
No one assigned
Labels
Team:Cloud Security Label for the Cloud Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update KSPM Screenshots
4 participants
@orouz @elasticmachine @tinnytintin10 @kfirpeled