-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove need for autodiscovery to monitor Istiod service. #4924
Conversation
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me!
Please make sure that the title of the PR is representative (are we doing it GA?) and that there is a clear path forward. If we want to give some time to the integration until it's officially GA consider filing a new GH issue just as a reminder for this.
nit: consider adding some manual testing notes for this PR, something simple but enough to bootstrap someone that might need to manually test or reproduce this package.
@@ -3,7 +3,7 @@ name: istio | |||
title: Istio | |||
description: Collect logs and metrics from the service mesh Istio with Elastic Agent. | |||
type: integration | |||
version: 0.2.1 | |||
version: 0.2.2 | |||
release: beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess since it will be still beta
you can change the title of the PR accordingly?
@@ -20,7 +20,7 @@ streams: | |||
required: true | |||
show_user: true | |||
default: | |||
- ${kubernetes.pod.ip}:15014 | |||
- istiod.istio-system:15014 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Package istio - 0.2.2 containing this change is available at https://epr.elastic.co/search?package=istio |
What does this PR do?
Remove need for autodiscovery to monitor Istiod service.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
metrics-istio.istiod*
error.message
is empty for all metric events.istio.istiod.metrics.pilot_inbound_updates.counter: exists
to view a sample of the dataset for one of the metrics used in the[Metrics Istio] Overview
dashboard[Metrics Istio] Overview
has no errors and some actual data.Related issues
Screenshots