Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSDB] [postgresql] Add dimensions for Datastream : BGWriter #5544

Merged
merged 5 commits into from
Mar 23, 2023
Merged

[TSDB] [postgresql] Add dimensions for Datastream : BGWriter #5544

merged 5 commits into from
Mar 23, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Mar 15, 2023 •
edited
Loading

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@agithomas agithomas requested a review from a team as a code owner March 15, 2023 10:00
@agithomas agithomas force-pushed the issue-5429-postgresql-tsdb-ds-bgwriter branch from b78fed6 to b1e1b62 Compare March 15, 2023 10:02
@agithomas agithomas mentioned this pull request Mar 15, 2023
Closed
22 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 15, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-23T09:18:45.209+0000

  • Duration: 18 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 57
Skipped 0
Total 57

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@agithomas agithomas force-pushed the issue-5429-postgresql-tsdb-ds-bgwriter branch from 8c051ed to 3ac3f3e Compare March 15, 2023 10:22
@elasticmachine
Copy link

elasticmachine commented Mar 15, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 93.333% (28/30) 👍
Lines 97.041% (164/169) 👍
Conditionals 100.0% (0/0) 💚

ritalwar
ritalwar approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 2f64d67 into elastic:main Mar 23, 2023
@elasticmachine
Copy link

Package postgresql - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=postgresql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritalwar ritalwar ritalwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agithomas @elasticmachine @ritalwar