[O11y][Nagios XI] Lens migration for visualizations to Kibana version 8.3.0 #5573

rajvi-patel-22 · 2023-03-17T10:51:17Z

Enhancement

What does this PR do?

Migrate visualizations to lens for Nagios XI integration package
Statistics for Nagios XI Lens migration:

Nagios XI dashboard	Before Migration		After Migration
	Lens	Visualization	Lens	Visualization
[Metrics Nagios XI] Hosts Dashboard	6	1	6	1
[Metrics Nagios XI] Overview	5	1	5	1
[Metrics Nagios XI] Events Dashboard	0	1	0	1
[Metrics Nagios XI] Services Dashboard	10	2	10	1
	21	5	21	4

Note: One visualization is migrated to the new control panels. Count of visualization is 4 after migration because all the dashboards have 1 markdown visualization whose alternative is not available in Lens hence we have not migrated those.

Checklist

I have added an entry to my package's changelog.yml file.
I have verified that panels are populated with data.
I have verified that panels are not distorted after being migrated to lens.
I have updated screenshots of dashboard.
I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

Migrated panels should be removed from visualization folder.
Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

Relates Lens Migration of OBS integrations #5221

Issues Identified

In input control visualization, we can make dependency filters that strictly depend on each other but in new controls, dependency filtering is possible but filters are not required to be strict. As per the discussion, this is the expected behavior of new controls.

elasticmachine · 2023-03-17T11:06:43Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-03-17T10:52:36.120+0000
Duration: 16 min 27 sec

Test stats 🧪

Test	Results
Failed	0
Passed	40
Skipped	0
Total	40

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2023-03-17T11:06:53Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`3/3`)	💚
Files	100.0% (`3/3`)	💚 3.432
Classes	100.0% (`3/3`)	💚 3.432
Methods	97.059% (`33/34`)	👍 5.899
Lines	95.23% (`1138/1195`)	👍 3.848
Conditionals	100.0% (`0/0`)	💚

kush-elastic

LGTM!

agithomas · 2023-03-17T14:46:02Z

Please revisit the color usage for the below viz

agithomas · 2023-03-17T15:02:11Z

Encourage you to create Smaller PRs going forward - One PR for either one dashboard / datastream.

There are two visualisation files but only one screenshot image updated. Please confirm on the number of modified dashboards

rajvi-patel-22 · 2023-03-20T06:57:37Z

Please revisit the color usage for the below viz

@agithomas, In this integration we have only migrated one visualization to new control panels. Apart from that we haven't touched any panels. The functionality/color palette of those panels are same as before. This is just the lens migration PR so we won't be changing any behavior/files as a part of this PR otherwise it will mess it up. However, If you strongly feel that this change needs to be done then we can raise a separate issue for that and track them separately.

rajvi-patel-22 · 2023-03-20T07:15:51Z

Encourage you to create Smaller PRs going forward - One PR for either one dashboard / datastream.

There are two visualisation files but only one screenshot image updated. Please confirm on the number of modified dashboards

@agithomas, I understand the number of changed files is quite big but only one visualization is migrated. This integration is not yet converted to by reference and because of that there is a separate file for each panel. When we are migrating dashboards to the newer versions, the new properties are being added and the version related properties (e.g., coreMigrationVersion and migrationVersion) are also getting updated. This is the reason behind increased number of file changes. Hence, creating different PR for one visualization seems irrational.

Yes, there are two visualization files but that doesn't mean it has two dashboards. The number of dashboards can be determined by the number of files falls under packages/nagios_xi/kibana/dashboard folder. This integration contains four dashbaords but we just updated the screenshot of one dashboard from which the panel was migrated.

agithomas · 2023-03-20T07:54:20Z

The functionality/color palette of those panels are same as before.

Can you elaborate the colour scheme used in the old dashboard ? Please refer and compare the two panels (circled in blue) in old and new dashboard.

agithomas · 2023-03-20T08:03:27Z

Hence, creating different PR for one visualization seems irrational.

I hoped you had looked at the comment more carefully. The requirement is to create one PR for one dashboard / one datastream. I didn't ask one PR per visualisation.

There may be cases when one dashboard represents data from multiple datastreams. At certain times, one datastream may have one dashboard. This is the reason why i mentioned - one PR per dashboard / datastream. Are there any challenges following this practise?

rajvi-patel-22 · 2023-03-20T09:32:27Z

Can you elaborate the colour scheme used in the old dashboard ? Please refer and compare the two panels (circled in blue) in old and new dashboard.

@agithomas, the screenshot of the [Metrics Nagios XI] Services Dashboard (uploaded with the integration package) does not sync with the Kibana files. Can you please refer to the below screenshot to compare the migrated visualization:

[Metrics Nagios XI] Services Dashboard before migration:

[Metrics Nagios XI] Services Dashboard After migration:

As mentioned in description, only control panels are migrated. Apart from that everything is in lens.
Old Control panels:

New control panels:

rajvi-patel-22 · 2023-03-20T09:40:10Z

Can you elaborate the colour scheme used in the old dashboard ?

Regarding colors in mentioned panels,

The custom colors are used in Swap Usage [Metrics Nagios XI] and Root Partition [Metrics Nagios XI].

The default color is used in Swap Usage Gauge [Metrics Nagios XI] and Root Partition Gauge [Metrics Nagios XI].

agithomas · 2023-03-20T10:57:33Z

Thanks for sharing the details.

agithomas · 2023-03-21T10:31:17Z

Please split the PR to smaller one - One per dashboard preferably.

agithomas · 2023-03-27T04:37:35Z

@rajvi-elastic , any progress on this PR?

rajvi-patel-22 · 2023-03-27T05:54:04Z

@rajvi-elastic , any progress on this PR?

@agithomas, In this integration, only one old control panel has been migrated to the new controls. And splitting this PR into multiple ones (either based on data-stream or dashboard) would be difficult because one file could belong to the both PRs. So we are waiting for your review only.

agithomas

LGTM!

Need additional clarification on screenshots

agithomas · 2023-03-27T17:32:47Z

I see that the screenshot that is deleted and the screenshot that is added are totally different. Please explain why?

rajvi-patel-22 · 2023-03-28T02:46:01Z

I see that the screenshot that is deleted and the screenshot that is added are totally different. Please explain why?

@agithomas, Can you please refer to this comment. I have mentioned over there. Please let me know if you need more information for the same.

agithomas

LGTM

elasticmachine · 2023-03-28T06:48:49Z

Package nagios_xi - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=nagios_xi

Migrate visualizations to lens 8.3.0

8106252

rajvi-patel-22 requested a review from a team as a code owner March 17, 2023 10:51

Update changelog

787b779

rajvi-patel-22 mentioned this pull request Mar 17, 2023

[O11y][Nagios XI] Lens Migration #5567

Closed

5 tasks

kush-elastic requested review from rameshelastic, lalit-satapathy, kush-elastic and agithomas March 17, 2023 10:54

kush-elastic assigned rajvi-patel-22 Mar 17, 2023

kush-elastic added enhancement New feature or request v8.3.0 Team:Service-Integrations Label for the Service Integrations team Integration:nagios_xi Nagios XI labels Mar 17, 2023

kush-elastic approved these changes Mar 17, 2023

View reviewed changes

agithomas previously approved these changes Mar 27, 2023

View reviewed changes

agithomas approved these changes Mar 28, 2023

View reviewed changes

kush-elastic merged commit 55d82e1 into elastic:main Mar 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[O11y][Nagios XI] Lens migration for visualizations to Kibana version 8.3.0 #5573

[O11y][Nagios XI] Lens migration for visualizations to Kibana version 8.3.0 #5573

rajvi-patel-22 commented Mar 17, 2023

elasticmachine commented Mar 17, 2023 •

edited

Loading

Build stats

Test stats 🧪

elasticmachine commented Mar 17, 2023

kush-elastic left a comment

agithomas commented Mar 17, 2023

agithomas commented Mar 17, 2023

rajvi-patel-22 commented Mar 20, 2023

rajvi-patel-22 commented Mar 20, 2023

agithomas commented Mar 20, 2023

agithomas commented Mar 20, 2023

rajvi-patel-22 commented Mar 20, 2023

rajvi-patel-22 commented Mar 20, 2023

agithomas commented Mar 20, 2023

agithomas commented Mar 21, 2023

agithomas commented Mar 27, 2023

rajvi-patel-22 commented Mar 27, 2023

agithomas left a comment

agithomas commented Mar 27, 2023

rajvi-patel-22 commented Mar 28, 2023 •

edited

Loading

agithomas left a comment

elasticmachine commented Mar 28, 2023

[O11y][Nagios XI] Lens migration for visualizations to Kibana version 8.3.0 #5573

[O11y][Nagios XI] Lens migration for visualizations to Kibana version 8.3.0 #5573

Conversation

rajvi-patel-22 commented Mar 17, 2023

What does this PR do?

Checklist

Author's Checklist

Related issues

Issues Identified

elasticmachine commented Mar 17, 2023 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

elasticmachine commented Mar 17, 2023

🌐 Coverage report

kush-elastic left a comment

Choose a reason for hiding this comment

agithomas commented Mar 17, 2023

agithomas commented Mar 17, 2023

rajvi-patel-22 commented Mar 20, 2023

rajvi-patel-22 commented Mar 20, 2023

agithomas commented Mar 20, 2023

agithomas commented Mar 20, 2023

rajvi-patel-22 commented Mar 20, 2023

rajvi-patel-22 commented Mar 20, 2023

agithomas commented Mar 20, 2023

agithomas commented Mar 21, 2023

agithomas commented Mar 27, 2023

rajvi-patel-22 commented Mar 27, 2023

agithomas left a comment

Choose a reason for hiding this comment

agithomas commented Mar 27, 2023

rajvi-patel-22 commented Mar 28, 2023 • edited Loading

agithomas left a comment

Choose a reason for hiding this comment

elasticmachine commented Mar 28, 2023

elasticmachine commented Mar 17, 2023 •

edited

Loading

rajvi-patel-22 commented Mar 28, 2023 •

edited

Loading