Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[integrations] [microsft message trace] - Deprecated basic auth and added support for Oauth2 #5775

Merged
merged 9 commits into from
Apr 5, 2023
Merged

[integrations] [microsft message trace] - Deprecated basic auth and added support for Oauth2 #5775

merged 9 commits into from
Apr 5, 2023

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Apr 3, 2023 •
edited by narph
Loading

Type of change

  • Enhancement

What does this PR do?

This deprecates the basic auth fields and adds support for OAuth2. This had to be done because Microsoft has
completely ended support of basic auth in Message Trace APIs since 31st March 2023. This has been also mentioned
here: https://techcommunity.microsoft.com/t5/exchange-team-blog/basic-authentication-deprecation-in-exchange-online-time-s-up/ba-p/3695312

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ShourieG ShourieG self-assigned this Apr 3, 2023
@ShourieG ShourieG requested a review from a team as a code owner April 3, 2023 14:40
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@ShourieG ShourieG changed the title Enhancement/ms message trace [integrations] [microsft message trace] - Deprecated basic auth and added support for Oauth2 Apr 3, 2023
@elasticmachine
Copy link

elasticmachine commented Apr 3, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-05T09:08:51.618+0000

  • Duration: 16 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 3, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (15/15) 💚
Lines 98.047% (251/256) 👎 -1.133
Conditionals 100.0% (0/0) 💚

efd6
efd6 reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the documentation for the log collection by PowerShell need to be updated?

packages/microsoft_exchange_online_message_trace/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/microsoft_exchange_online_message_trace/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/microsoft_exchange_online_message_trace/manifest.yml Show resolved Hide resolved
@romain-chanu romain-chanu mentioned this pull request Apr 4, 2023
Closed
@ShourieG
Copy link
Contributor Author

ShourieG commented Apr 4, 2023

@efd6 have updated the docs along with the powershell script.

@ShourieG
Copy link
Contributor Author

ShourieG commented Apr 5, 2023 •
edited
Loading

@efd6 the doc has been updated with a disclaimer

efd6
efd6 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes:

  • PowerShell is a trademark, so we make sure we use their typography.
  • The issue is less deprecation and more disablement.

packages/microsoft_exchange_online_message_trace/_dev/build/docs/README.md Outdated Show resolved Hide resolved
ShourieG and others added 2 commits April 5, 2023 14:25
@ShourieG @efd6
Update packages/microsoft_exchange_online_message_trace/_dev/build/do…
2b73634 
…cs/README.md

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@ShourieG
updated docs
37a9da6
@ShourieG ShourieG merged commit 631135a into elastic:main Apr 5, 2023
@ShourieG ShourieG deleted the enhancement/ms_message_trace branch April 5, 2023 09:26
@elasticmachine
Copy link

Package microsoft_exchange_online_message_trace - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_exchange_online_message_trace

@andrewkroh andrewkroh added the Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@ShourieG ShourieG

Labels
enhancement New feature or request Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShourieG @elasticmachine @efd6 @andrewkroh