[Cloudflare Logpush, Akamai] - Fixed bugs related to the gcs input #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
P1llus
approved these changes
May 11, 2023
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
bhapas
reviewed
May 11, 2023
kcreddy
approved these changes
May 11, 2023
|
@bhapas there are no system tests for the gcs or aws streams in akami or cloudflare, only tests using httpjson and http endpoint. The main reason is aws and gcs system tests will require implementing an emulator that can handle the respective SDK calls. Implementing this would be a separate task of it's own. |
|
Package akamai - 2.8.1 containing this change is available at https://epr.elastic.co/search?package=akamai |
|
Package cloudflare_logpush - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush |
chemamartinez
added a commit
to chemamartinez/integrations
that referenced
this pull request
May 12, 2023
4 tasks
chemamartinez
added a commit
to chemamartinez/integrations
that referenced
this pull request
May 15, 2023
chemamartinez
added a commit
to chemamartinez/integrations
that referenced
this pull request
May 16, 2023
chemamartinez
added a commit
to chemamartinez/integrations
that referenced
this pull request
May 19, 2023
P1llus
pushed a commit
that referenced
this pull request
Jun 20, 2023
* Add gateway_dns data stream for Cloudflare Logpush * Add gateway_http data stream for Cloudflare Logpush * Add gateway_network data stream for Cloudflare Logpush * Add network_session data stream for Cloudflare Logpush * Update new data streams with latest changes from #6164 and #6053 * Add casb_findings data stream for Cloudflare Logpush * Add access_request data stream for Cloudflare Logpush * Rename CASB sample log * Add device_posture data stream for Cloudflare Logpush * Update new data streams with latest changes from #6199 * Add requested changes for data streams * Fix typo in network analytics pipeline * Fix missing field in Device Posture pipeline * Add dashboards for ZT events * Fix the use of event.outcome and event.type * Update Cloudflare Logpush dashboards * Update pipeline and system tests * Update Cloudflare Logpush screenshots * Add screenshots to manifest * Update preference in timestamp formats * Increase Kibana version to 8.7.0 * Update some filters in cloudflare logpush dashboards
andrewkroh
added
Integration:akamai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Please label this PR with one of the following labels, depending on the scope of your change:
What does this PR do?
This fixes a minor variable naming bug for the akamai & cloudflare logpush packages, that caused the input to stop after a
single pass.
Checklist
changelog.ymlfile.Related issues