Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloudflare Logpush, Akamai] - Fixed variable naming bugs related to the gcs input #6199

Merged
merged 10 commits into from
May 16, 2023
Merged

[Cloudflare Logpush, Akamai] - Fixed variable naming bugs related to the gcs input #6199

merged 10 commits into from
May 16, 2023

Conversation

ShourieG
Copy link
Contributor

Type of change

  • Bug

What does this PR do?

This fixes some variable naming bugs for the akamai & cloudflare logpush packages, that could cause potential issues in future.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ShourieG ShourieG requested a review from a team as a code owner May 15, 2023 10:26
@ShourieG ShourieG self-assigned this May 15, 2023
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@ShourieG ShourieG requested a review from kcreddy May 15, 2023 10:32
@elasticmachine
Copy link

elasticmachine commented May 15, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-15T11:28:25.354+0000

  • Duration: 18 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 50
Skipped 0
Total 50

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 15, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 100.0% (8/8) 💚
Classes 100.0% (8/8) 💚
Methods 100.0% (109/109) 💚 3.846
Lines 93.822% (2779/2962) 👎 -6.178
Conditionals 100.0% (0/0) 💚

@ShourieG
Copy link
Contributor Author

/test

@ShourieG ShourieG requested a review from P1llus May 15, 2023 11:58
kcreddy
kcreddy approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM.
Just a thought,.. instead of changing manifest.yml parameters to number_of_workers, we could have changed input to use max_workers parameter. That maybe slightly cleaner since number_of_workers is already being used by AWS-S3 input in multiple packages.

Using a script on this parameter could be a challenge in the future?

kcreddy
kcreddy approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM.
Just a thought,.. instead of changing manifest.yml parameters to number_of_workers, we could have changed input to use max_workers parameter. That maybe slightly cleaner since number_of_workers is already being used by AWS-S3 input in multiple packages.

Using a script on this parameter could be a challenge in the future?

@ShourieG ShourieG merged commit 7c81c48 into elastic:main May 16, 2023
1 check passed
@ShourieG ShourieG deleted the bugfix/logpush_akamai branch May 16, 2023 06:06
@elasticmachine
Copy link

Package akamai - 2.8.2 containing this change is available at https://epr.elastic.co/search?package=akamai

@elasticmachine
Copy link

Package cloudflare_logpush - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush

chemamartinez added a commit to chemamartinez/integrations that referenced this pull request May 19, 2023
@chemamartinez
Update new data streams with latest changes from elastic#6199
ff9abcc
P1llus pushed a commit that referenced this pull request Jun 20, 2023
@chemamartinez
Increase the ZT event coverage for Cloudflare Logpush (#6132)
bfdfe5f 
* Add gateway_dns data stream for Cloudflare Logpush

* Add gateway_http data stream for Cloudflare Logpush

* Add gateway_network data stream for Cloudflare Logpush

* Add network_session data stream for Cloudflare Logpush

* Update new data streams with latest changes from #6164 and #6053

* Add casb_findings data stream for Cloudflare Logpush

* Add access_request data stream for Cloudflare Logpush

* Rename CASB sample log

* Add device_posture data stream for Cloudflare Logpush

* Update new data streams with latest changes from #6199

* Add requested changes for data streams

* Fix typo in network analytics pipeline

* Fix missing field in Device Posture pipeline

* Add dashboards for ZT events

* Fix the use of event.outcome and event.type

* Update Cloudflare Logpush dashboards

* Update pipeline and system tests

* Update Cloudflare Logpush screenshots

* Add screenshots to manifest

* Update preference in timestamp formats

* Increase Kibana version to 8.7.0

* Update some filters in cloudflare logpush dashboards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

@kcreddy kcreddy kcreddy approved these changes

Assignees

@ShourieG ShourieG

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ShourieG @elasticmachine @P1llus @kcreddy