-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
okta: add support for okta.device field group and okta.target.detailEntry fields #6302
Conversation
- name: okta.device | ||
title: Client | ||
type: group | ||
fields: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SpencerLN I was unable to find docs for these fields, so they are trite restatements of the name. If you know of any docs I'll fix this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I was able to find was https://help.okta.com/oie/en-us/Content/Topics/identity-engine/devices/el-device-attributes.htm, but I think the descriptions you provided for the fields more or less cover it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are good, I will update. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's currently no field doc for okta.target.detailEntry
. This doesn't get complained about since okta.target
is flattened. Are you fine with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we're fine with that.
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will wait for Spencer. |
Package okta - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=okta |
1 similar comment
Package okta - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=okta |
What does this PR do?
Adds support for the
okta.device
field group and retains theokta.target.detailEntry.{methodTypeUsed,methodUsedVerifiedProperties}
fields.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots