Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okta: add support for okta.device field group and okta.target.detailEntry fields #6302

Merged
merged 3 commits into from
May 26, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 24, 2023

What does this PR do?

Adds support for the okta.device field group and retains the okta.target.detailEntry.{methodTypeUsed,methodUsedVerifiedProperties} fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented May 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-24T22:48:28.702+0000

  • Duration: 14 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

- name: okta.device
title: Client
type: group
fields:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpencerLN I was unable to find docs for these fields, so they are trite restatements of the name. If you know of any docs I'll fix this up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I was able to find was https://help.okta.com/oie/en-us/Content/Topics/identity-engine/devices/el-device-attributes.htm, but I think the descriptions you provided for the fields more or less cover it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are good, I will update. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's currently no field doc for okta.target.detailEntry. This doesn't get complained about since okta.target is flattened. Are you fine with that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we're fine with that.

@elasticmachine
Copy link

elasticmachine commented May 24, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (19/19) 💚 4.368
Lines 91.948% (571/621) 👍 1.12
Conditionals 100.0% (0/0) 💚

@efd6 efd6 changed the title okta: add support for okta.device field group okta: add support for okta.device field group and okta.target.detailEntry fields May 24, 2023
@efd6 efd6 marked this pull request as ready for review May 24, 2023 04:33
@efd6 efd6 requested a review from a team as a code owner May 24, 2023 04:33
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6
Copy link
Contributor Author

efd6 commented May 24, 2023

Will wait for Spencer.

@efd6 efd6 merged commit 31ab6f2 into elastic:main May 26, 2023
@elasticmachine
Copy link

Package okta - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=okta

1 similar comment
@elasticmachine
Copy link

Package okta - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=okta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:okta Okta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Okta] Parse device details to a new field [Okta] Preserve okta.target.detailEntry field
4 participants