-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ti_misp: fix timestamp format sent to API #6482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌐 Coverage report
|
Also add constraint on test server to match the API definition. API: https://www.misp-project.org/openapi/#tag/Events/operation/restSearchEvents
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I verified the initial requests contain unix timestamps.
"event.original": "POST /events/restSearch HTTP/1.1\r\nHost: host.docker.internal\r\nUser-Agent: Elastic-Filebeat/8.7.1 (linux; amd64; bda40535cf0743b97017512e6af6d661eeef956e; 2023-04-23 04:33:29 +0000 UTC)\r\nContent-Length: 72\r\nAccept: application/json\r\nAuthorization: hM1it4KA56pLDW5jJmlXTKZMsFV9RBpeSj3ZCu1Z\r\nContent-Type: application/json\r\nAccept-Encoding: gzip\r\n\r\n{\"limit\":\"10\",\"page\":\"1\",\"returnFormat\":\"json\",\"timestamp\":\"1685623795\"}",
"event.original": "POST /attributes/restSearch HTTP/1.1\r\nHost: host.docker.internal\r\nUser-Agent: Elastic-Filebeat/8.7.1 (linux; amd64; bda40535cf0743b97017512e6af6d661eeef956e; 2023-04-23 04:33:29 +0000 UTC)\r\nContent-Length: 72\r\nAccept: application/json\r\nAuthorization: hM1it4KA56pLDW5jJmlXTKZMsFV9RBpeSj3ZCu1Z\r\nContent-Type: application/json\r\nAccept-Encoding: gzip\r\n\r\n{\"limit\":\"10\",\"page\":\"1\",\"returnFormat\":\"json\",\"timestamp\":\"1685623788\"}",
Package ti_misp - 1.15.1 containing this change is available at https://epr.elastic.co/search?package=ti_misp |
sodhikirti07
pushed a commit
that referenced
this pull request
Jun 15, 2023
Also add constraint on test server to match the API definition. API: https://www.misp-project.org/openapi/#tag/Events/operation/restSearchEvents
This was referenced Jan 31, 2024
chrisberkhout
added a commit
to elastic/beats
that referenced
this pull request
Feb 8, 2024
Update the HTTP JSON input configuration for the Threat Intel module's misp fileset with pagination fixes that were done earlier in the Agent-based MISP integration, in these PRs: - Fix timestamp format sent to API elastic/integrations#6482 - Fix duplicate requests for page 1 elastic/integrations#6495 - Keep the same timestamp for later pages elastic/integrations#6649 - Pagination fixes elastic/integrations#9073
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
Feb 8, 2024
Update the HTTP JSON input configuration for the Threat Intel module's misp fileset with pagination fixes that were done earlier in the Agent-based MISP integration, in these PRs: - Fix timestamp format sent to API elastic/integrations#6482 - Fix duplicate requests for page 1 elastic/integrations#6495 - Keep the same timestamp for later pages elastic/integrations#6649 - Pagination fixes elastic/integrations#9073 (cherry picked from commit b7fc69a)
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
Feb 8, 2024
Update the HTTP JSON input configuration for the Threat Intel module's misp fileset with pagination fixes that were done earlier in the Agent-based MISP integration, in these PRs: - Fix timestamp format sent to API elastic/integrations#6482 - Fix duplicate requests for page 1 elastic/integrations#6495 - Keep the same timestamp for later pages elastic/integrations#6649 - Pagination fixes elastic/integrations#9073 (cherry picked from commit b7fc69a)
chrisberkhout
pushed a commit
to elastic/beats
that referenced
this pull request
Feb 9, 2024
…#37923) [filebeat][threatintel] MISP pagination fixes (#37898) Update the HTTP JSON input configuration for the Threat Intel module's misp fileset with pagination fixes that were done earlier in the Agent-based MISP integration, in these PRs: - Fix timestamp format sent to API elastic/integrations#6482 - Fix duplicate requests for page 1 elastic/integrations#6495 - Keep the same timestamp for later pages elastic/integrations#6649 - Pagination fixes elastic/integrations#9073
chrisberkhout
pushed a commit
to elastic/beats
that referenced
this pull request
Feb 9, 2024
…#37924) [filebeat][threatintel] MISP pagination fixes (#37898) Update the HTTP JSON input configuration for the Threat Intel module's misp fileset with pagination fixes that were done earlier in the Agent-based MISP integration, in these PRs: - Fix timestamp format sent to API elastic/integrations#6482 - Fix duplicate requests for page 1 elastic/integrations#6495 - Keep the same timestamp for later pages elastic/integrations#6649 - Pagination fixes elastic/integrations#9073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This make the timestamp be sent as unix seconds, rather than
time.UnixDate
. Also add constraint on test server to match the API definition.API: https://www.misp-project.org/openapi/#tag/Events/operation/restSearchEvents
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots