Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: allow DNS query responses to have no data #6508

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 7, 2023

What does this PR do?

This allows DNS query responses to have no data as can be seen for example with SRV responses.

Test event provided in elastic/beats#35207.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jun 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-09T05:53:43.389+0000

  • Duration: 15 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -9.478
Classes 87.5% (7/8) 👎 -9.478
Methods 83.696% (77/92) 👎 -8.038
Lines 92.813% (5153/5552) 👍 0.769
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 7, 2023 23:52
@efd6 efd6 requested review from a team as code owners June 7, 2023 23:52
@efd6 efd6 requested review from ycombinator and belimawr June 7, 2023 23:52
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit 70c93ab into elastic:main Jun 13, 2023
@elasticmachine
Copy link

Package windows - 1.23.0 containing this change is available at https://epr.elastic.co/search?package=windows

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:windows Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants