Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: add support for sysmon 15.0/event 29 #6761

Merged
merged 1 commit into from Jul 9, 2023
Merged

windows: add support for sysmon 15.0/event 29 #6761

merged 1 commit into from Jul 9, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 30, 2023

What does this PR do?

Adds a test case for sysmon 15.0/event 29.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 30, 2023
@elasticmachine
Copy link

elasticmachine commented Jun 30, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-09T21:52:27.751+0000

  • Duration: 15 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 30, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -9.635
Classes 87.5% (7/8) 👎 -9.635
Methods 83.696% (77/92) 👎 -8.459
Lines 92.82% (5158/5557) 👍 1.566
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 30, 2023 02:48
@efd6 efd6 requested review from a team as code owners June 30, 2023 02:48
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 force-pushed the 6748-windows branch 2 times, most recently from 8bac4e8 to 3a25c7b Compare June 30, 2023 08:15
@efd6 efd6 changed the title windows: add test case for sysmon 15.0/event 29 windows: add support for sysmon 15.0/event 29 Jun 30, 2023
ebeahan
ebeahan approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewkroh
andrewkroh reviewed Jul 7, 2023
View reviewed changes
...ges/windows/data_stream/sysmon_operational/_dev/test/pipeline/test-events.json-expected.json
"ecs": {
"version": "8.0.0"
},
"event": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to have an event.action populated with the sysmon event name like FileExecutableDetected. But none of the other events have it at the moment either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll send another change for that.

@efd6
windows: add support for sysmon 15.0/event 29
57ccb06 
Test case generated from XML document provided by user in elastic#6748.
@efd6 efd6 merged commit 623136c into elastic:main Jul 9, 2023
4 checks passed
@elasticmachine
Copy link

Package windows - 1.25.0 containing this change is available at https://epr.elastic.co/search?package=windows

@efd6 efd6 mentioned this pull request Jul 9, 2023
Merged
4 tasks
gizas pushed a commit that referenced this pull request Sep 5, 2023
@efd6 @gizas
windows: add support for sysmon 15.0/event 29 (#6761)
c8a601e 
Test case generated from XML document provided by user in #6748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@ebeahan ebeahan ebeahan approved these changes

@pierrehilbert pierrehilbert Awaiting requested review from pierrehilbert pierrehilbert is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add coverage for sysmon 15.0/event 29
4 participants
@efd6 @elasticmachine @andrewkroh @ebeahan