Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: set event.action to the event's sysmon name #6882

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 9, 2023

What does this PR do?

Sets event.action to the event's sysmon name.

Event details from https://learn.microsoft.com/en-us/sysinternals/downloads/sysmon.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jul 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-09T23:45:47.381+0000

  • Duration: 16 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👍
Classes 87.5% (7/8) 👍
Methods 83.696% (77/92) 👍
Lines 92.858% (5188/5587) 👍 0.039
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review July 10, 2023 04:04
@efd6 efd6 requested review from a team as code owners July 10, 2023 04:04
@efd6 efd6 requested review from ycombinator and faec July 10, 2023 04:04
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 93bc803 into elastic:main Jul 10, 2023
1 check passed
@elasticmachine
Copy link

Package windows - 1.26.0 containing this change is available at https://epr.elastic.co/search?package=windows

@andrewkroh
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:windows Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants